fix: Reorder context assignment in producer code. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianakhuang
force-pushed
the
diana/reorder-contexts
branch
from
9245e0e to
aeb8d24
Compare
rgraber
reviewed
Aug 28, 2023
dianakhuang
force-pushed
the
diana/reorder-contexts
branch
from
aeb8d24 to
67eaea1
Compare
In error logging, we did not have the full_topic available for searching/alerting because of the order in which these assignments happened. Reordering them to try to ensure we always get the full_topic in context. edx/edx-arch-experiments#411
dianakhuang
force-pushed
the
diana/reorder-contexts
branch
from
67eaea1 to
07de876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In error logging, we did not have the full_topic
available for searching/alerting because of the order in which these assignments happened. Reordering them to try to ensure we always get the full_topic in context.
edx/edx-arch-experiments#411
Merge checklist:
Check off if complete or not applicable: