Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make signal argument optional #22

Merged
merged 1 commit into from
May 15, 2023

Conversation

rgraber
Copy link
Contributor

@rgraber rgraber commented May 12, 2023

Description:
Make the 'signal' argument to the consumer optional in preparation for deprecation. Remove checking against the passed signal since more than one signal type may come from the same topic. See https://openedx-events.readthedocs.io/en/latest/decisions/0010-multiple-event-types-per-topic.html.

GH: openedx/openedx-events#218

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@bmtcril bmtcril merged commit 0ebee6a into openedx:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants