Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate deprecated Table to DataTable for RegisteredLearnersTable #1289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zwidekalanga
Copy link
Contributor

@zwidekalanga zwidekalanga commented Aug 30, 2024

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Screenshot

Screenshot 2024-09-13 at 9 23 22 AM

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 85.35%. Comparing base (115c430) to head (69f4117).

Files with missing lines Patch % Lines
...dLearnersTable/data/hooks/useRegisteredLearners.js 26.47% 21 Missing and 4 partials ⚠️
src/components/RegisteredLearnersTable/index.jsx 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
- Coverage   85.52%   85.35%   -0.17%     
==========================================
  Files         564      565       +1     
  Lines       12351    12392      +41     
  Branches     2621     2625       +4     
==========================================
+ Hits        10563    10577      +14     
- Misses       1729     1752      +23     
- Partials       59       63       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/ENT-8447 branch 2 times, most recently from acea660 to 5aa50bd Compare September 12, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant