Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] fix: Update custom SSO buttons to use brand colors #1208

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Mar 27, 2024

Description

This pull request is a backport from the master branch #1165.
The main goal is to make the buttons reflected to the primary paragon color by using the variable provided by the Paragon library.

Screenshots

Before After
Screenshot at Mar 27 14-03-45 Screenshot at Mar 27 14-01-11

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@9f503eb). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master    #1208   +/-   ##
=============================================================
  Coverage                              ?   87.14%           
=============================================================
  Files                                 ?      124           
  Lines                                 ?     2295           
  Branches                              ?      635           
=============================================================
  Hits                                  ?     2000           
  Misses                                ?      286           
  Partials                              ?        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Description: Update custom SSO buttons to use brand colors
VAN-1838
@ihor-romaniuk ihor-romaniuk changed the title fix: apply primary color to common oauth buttons fix: Update custom SSO buttons to use brand colors Mar 27, 2024
@ihor-romaniuk ihor-romaniuk changed the title fix: Update custom SSO buttons to use brand colors [Backport] fix: Update custom SSO buttons to use brand colors Mar 27, 2024
@ihor-romaniuk ihor-romaniuk added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 27, 2024
@ihor-romaniuk ihor-romaniuk force-pushed the fix/apply-brand-color-to-oauth-buttons branch from ac23313 to 12d0c79 Compare March 27, 2024 13:25
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 27, 2024
@mphilbrick211 mphilbrick211 requested a review from a team March 27, 2024 20:03
@mphilbrick211
Copy link

Hi @openedx/2u-vanguards! This should be all set, as the master has been merged. Thanks!

@zainab-amir zainab-amir merged commit 2eab85e into openedx:open-release/quince.master Apr 1, 2024
7 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ihor-romaniuk ihor-romaniuk deleted the fix/apply-brand-color-to-oauth-buttons branch April 18, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants