fix: add new entry for another US label #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahtesham-quraish
force-pushed
the
ahtesham/van-1900
branch
from
c46320f to
36bbecf
Compare
| @@ -97,7 +97,7 @@ const CountryField = (props) => { | |||
| }; | |||
|
|
|||
| const getCountryList = () => countryList.map((country) => ( | |||
| <FormAutosuggestOption key={country[COUNTRY_CODE_KEY]} id={country[COUNTRY_CODE_KEY]}> | |||
| <FormAutosuggestOption key={country[COUNTRY_DISPLAY_KEY]} id={country[COUNTRY_CODE_KEY]}> | |||
There was a problem hiding this comment.
Would it be fine if there are two same IDs? Would it work?
{
code: 'US', name: 'United States of America',
code: 'US', name: 'United States',
}
736a2ba to
0f1ec8b
Compare
Comment on lines
36
to
38
| // The reason for adding the entry 'United States' is that sometime browser aut-fill the form with the 'Unites States' | ||
| // instead 'United States of America' which does not exists in country dropdown list and gets the user confused | ||
| // and unable to create account. So we added the United States entry in dropdown list. |
There was a problem hiding this comment.
Suggested change
| // The reason for adding the entry 'United States' is that sometime browser aut-fill the form with the 'Unites States' | |
| // instead 'United States of America' which does not exists in country dropdown list and gets the user confused | |
| // and unable to create account. So we added the United States entry in dropdown list. | |
| /** The reason for adding the entry 'United States' is that Chrome browser aut-fill the form with the 'Unites | |
| States' instead of 'United States of America' if the user saved their address which does not exist in the country dropdown list and gets the user | |
| confused and unable to create an account. So we added the United States entry in the dropdown list. | |
| */ |
mubbsharanwar
approved these changes
May 2, 2024
Description: Add new entry for for another US label which is United States 1900
ahtesham-quraish
force-pushed
the
ahtesham/van-1900
branch
from
0f1ec8b to
69be4bd
Compare
mubbsharanwar
added a commit
that referenced
this pull request
Jun 7, 2024
* feat: Hide preloaders for third party auth providers if they are disabled * feat: remove username from the registration from (#1201) (#1241) Co-authored-by: Attiya Ishaque <atiya.ishaq@arbisoft.com> * fix: add new entry for another US label (#1244) Add new entry for for another US label which is United States * feat: implement multi step registration experiment Rebase 2u main with master (#1228) * chore(deps): update dependency babel-plugin-formatjs to v10.5.14 * fix(deps): update dependency @edx/frontend-platform to v7.1.3 * fix(deps): update font awesome to v6.5.2 * chore(deps): update dependency @openedx/frontend-build to v13.1.4 * fix(deps): update dependency @openedx/paragon to v22.2.1 * fix(deps): update dependency algoliasearch to v4.23.3 * fix(deps): update dependency algoliasearch-helper to v3.17.0 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: add multi step registration eventing (#1226) * feat: implement multi step registration experiment * feat: add multi step registration eventing * fix: fix register button width * fix: fix register button loader for control * feat: capture marketing lead in experiment events (#1243) * revert: multistep registration experiment revert multistep registration experiment changes VAN-1930 * feat: implement auto generated username experiment (#1248) * feat: implement auto generated username registration exp * feat: add page event for reset password (#1253) Description: Add page event for reset password page VAN-1929 --------- Co-authored-by: Stanislav Lunyachek <stanislav.lunyachek@raccoongang.com> Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com> Co-authored-by: Attiya Ishaque <atiya.ishaq@arbisoft.com> Co-authored-by: Blue <ahtesham-quraish@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Syed Sajjad Hussain Shah <ssajjad@2u.com>
mubbsharanwar
added a commit
that referenced
this pull request
Sep 12, 2024
* feat: Hide preloaders for third party auth providers if they are disabled * feat: remove username from the registration from (#1201) (#1241) Co-authored-by: Attiya Ishaque <atiya.ishaq@arbisoft.com> * fix: add new entry for another US label (#1244) Add new entry for for another US label which is United States * feat: implement multi step registration experiment Rebase 2u main with master (#1228) * chore(deps): update dependency babel-plugin-formatjs to v10.5.14 * fix(deps): update dependency @edx/frontend-platform to v7.1.3 * fix(deps): update font awesome to v6.5.2 * chore(deps): update dependency @openedx/frontend-build to v13.1.4 * fix(deps): update dependency @openedx/paragon to v22.2.1 * fix(deps): update dependency algoliasearch to v4.23.3 * fix(deps): update dependency algoliasearch-helper to v3.17.0 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: add multi step registration eventing (#1226) * feat: implement multi step registration experiment * feat: add multi step registration eventing * fix: fix register button width * fix: fix register button loader for control * feat: capture marketing lead in experiment events (#1243) * revert: multistep registration experiment revert multistep registration experiment changes VAN-1930 * feat: implement auto generated username experiment (#1248) * feat: implement auto generated username registration exp * feat: add page event for reset password (#1253) Description: Add page event for reset password page VAN-1929 --------- Co-authored-by: Stanislav Lunyachek <stanislav.lunyachek@raccoongang.com> Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com> Co-authored-by: Attiya Ishaque <atiya.ishaq@arbisoft.com> Co-authored-by: Blue <ahtesham-quraish@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Syed Sajjad Hussain Shah <ssajjad@2u.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Description
Add new entry for for another US label which is United States
JIRA
VAN-1900
How Has This Been Tested?
It has been tested locally.
Screenshots: