Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added observability events for video detail page #1159

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad irfanuddinahmad commented Aug 20, 2024

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-9314 branch 3 times, most recently from 0372026 to 05f0693 Compare August 21, 2024 13:11
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (196fdb5) to head (60906da).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
+ Coverage   88.09%   88.21%   +0.11%     
==========================================
  Files         394      394              
  Lines        8360     8392      +32     
  Branches     2016     2059      +43     
==========================================
+ Hits         7365     7403      +38     
+ Misses        953      947       -6     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irfanuddinahmad irfanuddinahmad merged commit 272f6dd into master Sep 2, 2024
7 checks passed
@irfanuddinahmad irfanuddinahmad deleted the iahmad/ENT-9314 branch September 2, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants