Hajorg/au 2090 peer review bug #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 89.29% 89.29%
=======================================
Files 143 143
Lines 2205 2205
Branches 476 477 +1
=======================================
Hits 1969 1969
+ Misses 226 222 -4
- Partials 10 14 +4 ☔ View full report in Codecov by Sentry. |
KristinAoki
approved these changes
Dec 4, 2024
|
LGTM! I am not sure why the code coverage decreased. You might want to add a test for the case that you were fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves issue where ORA peer review throws error and display "Try again" when submitting peer review
Also, this PR resolves visual glitch with prompt submission validation message.