Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Install dependencies using npm 8 #702

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

edx-requirements-bot
Copy link
Contributor

We've added support for Node16 and MFEs will be deployed to Node16 now and node16 comes with npm8 so we need to generate package-lock using npm8

Additional information from script execution

Python code cleanup by the cleanup-python-code Jenkins job.

This pull request was generated by the cleanup-python-code Jenkins job, which ran
npm install



The following packages were installed:
``

@Jawayria Jawayria force-pushed the jenkins/npm-8-155981f branch 5 times, most recently from 62e7e46 to 1e0ad6a Compare April 7, 2022 14:42
@Jawayria Jawayria requested a review from waheedahmed April 8, 2022 09:54
@Jawayria Jawayria force-pushed the jenkins/npm-8-155981f branch 3 times, most recently from e4b256f to 20703fc Compare April 8, 2022 11:06
@Jawayria Jawayria force-pushed the jenkins/npm-8-155981f branch from 6f30c16 to 8524b6c Compare April 8, 2022 11:16
@@ -14,14 +14,15 @@ jobs:
strategy:
matrix:
node: [12, 14, 16]
npm: [6,8]
npm: [6, 8.5.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facing some issues with npm 8.6.0 currently so pinned the version to 8.5.0

@Jawayria Jawayria merged commit 5fe8330 into master Apr 8, 2022
@Jawayria Jawayria deleted the jenkins/npm-8-155981f branch April 8, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants