Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add typescript files to coverage report #571

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Jul 17, 2024

Description

Currently, ts and tsx files are not included in the coverage report. This PR updates the collectCoverageFrom param from jest.config to fix the issue.

More information

Here is a course-autoring PR using a version with this change and the coverage report including ts files.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 17, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 17, 2024

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-build. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good 👍 The next would be do a test using this version in frontend-course-authoring

@rpenido rpenido marked this pull request as ready for review July 19, 2024 20:08
@rpenido
Copy link
Contributor Author

rpenido commented Jul 19, 2024

@rpenido Looks good 👍 The next would be do a test using this version in frontend-course-authoring

Sure @ChrisChV!
Here is a course-autoring PR using a version with this change and the coverage report including ts files.

@bradenmacdonald Could you help us to find a reviewer here?

@ChrisChV
Copy link

@rpenido Looks good 👍 The next would be do a test using this version in frontend-course-authoring

Sure @ChrisChV! Here is a course-autoring PR using a version with this change and the coverage report including ts files.

@bradenmacdonald Could you help us to find a reviewer here?

@rpenido I think codecov/patch is still running, could you check if is something about your changes?

@rpenido
Copy link
Contributor Author

rpenido commented Jul 23, 2024

I think codecov/patch is still running, could you check if is something about your changes?

@ChrisChV I re-ran the CI and it seems fine now: openedx/frontend-app-course-authoring#1155

@@ -28,6 +28,7 @@ module.exports = {
},
collectCoverageFrom: [
'src/**/*.{js,jsx}',
'src/**/*.{ts,tsx}',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd likely combine these lines into:

'src/**/*.{js,jsx,ts,tsx}',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Done: da2c6f3

@rpenido rpenido force-pushed the rpenido/fal-3777-add-typescript-files-to-coverage branch from b6a29a4 to da2c6f3 Compare July 23, 2024 18:13
@dcoa dcoa merged commit ae8ce98 into openedx:master Jul 23, 2024
5 checks passed
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-semantic-release-bot

🎉 This PR is included in version 14.0.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bradenmacdonald bradenmacdonald deleted the rpenido/fal-3777-add-typescript-files-to-coverage branch July 24, 2024 16:24
@openedx-semantic-release-bot

🎉 This PR is included in version 15.0.0-alpha.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants