Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace @edx/paragon with @openedx/paragon #143

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Mar 25, 2024

Why?

  • @edx/paragon is getting moved to @openedx/paragon
  • @edx/frontend-build is getting moved to @openedx/frontend-build
  • learning MFE is trying to use plugin slot. It require @edx/frontend-platform@7 and react-intl@6

BREAKING CHANGE:

  • replace @edx/paragon with @openedx/paragon
  • upgrade @edx/frontend-platform to version 7
  • replace @edx/frontend-build with @openedx/frontend-build

BREAKING CHANGE:
- replace @edx/paragon with @openedx/paragon
- upgrade @edx/frontend-platform to version 7
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.06%. Comparing base (10dd052) to head (7a5e022).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files          68       68           
  Lines        1079     1079           
  Branches      295      295           
=======================================
  Hits         1015     1015           
  Misses         59       59           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leangseu-edx leangseu-edx marked this pull request as ready for review March 25, 2024 22:28
@leangseu-edx leangseu-edx merged commit c2f041f into main Mar 26, 2024
8 checks passed
@leangseu-edx leangseu-edx deleted the lk/deprecate-edx-paragon branch March 26, 2024 13:54
@abdullahwaheed
Copy link
Contributor

[question], why this work is redone when we already had an open PR for the same work. we have notified the squad about these changes as well.

cc: @jristau1984

@leangseu-edx
Copy link
Contributor Author

@abdullahwaheed sorry, I wasn't aware of that pr. I was just focusing on getting other feature unblocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants