fix: remove duplicate language in onboarding instructions #144
Conversation
| @@ -51,14 +51,6 @@ const SubmittedOnboardingExamInstructions = () => { | |||
| <p> | |||
| <FormattedMessage | |||
| id="exam.SubmittedProctoredExamInstructions.text4" | |||
| defaultMessage={'If you do not have an onboarding profile with the system, Verificient ' | |||
There was a problem hiding this comment.
This makes sense to me, but I have a concern about the ID.
Because we're removing the string with the ID exam.SubmittedProctoredExamInstructions.text5, I looked around for where it's used and where the string with ID exam.SubmittedProctoredExamInstructions.text1 is used, because it'll be the ID of the string on the page. I noticed that exam.SubmittedProctoredExamInstructions.text1 is used to identify two unique strings in this library. I'm not sure what happens when two IDs are used for two different strings - how does the Open edX translations code decide which string to send to Transifex for that ID? At least in this locale, the other string is associated with this ID. I think it would be safer to keep this string with the ID exam.SubmittedProctoredExamInstructions.text5 because it's unique. Do you see any issues with keeping this ID instead?
There was a problem hiding this comment.
No, that makes a lot of sense! I will change this back to using exam.SubmittedProctoredExamInstructions.text5
There was a problem hiding this comment.
Ah, sorry. I swore this string had ID text5 before, but now it's text4 🫨. I think the string that we are keeping (which has ID text1 above) should have text4. text1 is associated with two different strings currently, so if we switch to text4, then only text4 will be associated with this string, right?
There was a problem hiding this comment.
I see what you're saying! Sorry I didn't catch that before. I will update the ID for text1 to be text4
alangsto
force-pushed
the
alangsto/update_onboarding_instructions
branch
from
59c1b68 to
fec02a0
Compare
alangsto
force-pushed
the
alangsto/update_onboarding_instructions
branch
from
fec02a0 to
dab850e
Compare
COSMO-233
A section of text in the submitted onboarding instructions was duplicated. I believe this may have been an oversight when copying over text for the instructions.