-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the options for icon
in catalog-info.yaml
#568
Comments
@feanil: I should probably open a separate ticket, but I just noticed that the proposed |
icon
in catalog-info.yaml
@feanil could you provide any insight here? What would you like to see from this |
I honestly have no opinion on what the value of Icon should be, it's meant to be representative of the link that it is associated with. The lack of guidance on the icon is because I don't think it needs guidance. I guess we could say that if you're not sure about what to choose, just choose the "Web" icon? Would that be helpful? |
I've poked around backstage and I don't even see the use of this "web" icon: anywhere. Do we need this field? On the Search page I see an icon for "Software Catalog" On the Home page I see no icons, and when I click in to a repo like https://backstage.openedx.org/catalog/default/component/openedx-learning i similarly don't see this icon. |
Ah gotcha. That icon doesn't match the "Web" icon from https://mui.com/material-ui/material-icons/ so I missed it. If the icon set Backstage uses doesn't even match the one that's linked, it'll be difficult to pick an appropriate alternate. I'm inclined to say we should just always use "Web". |
The use of
icon
should be clarified in the docs for catalog-info.yaml:https://github.com/openedx/open-edx-proposals/edit/master/oeps/processes/oep-0055/decisions/0001-use-backstage-to-support-maintainers.rst
The following list is very clear, it gives the acceptable type values:
Here are the current docs for icon:
What it would be useful to know is:
type
values of service, website, or library?The text was updated successfully, but these errors were encountered: