Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the options for icon in catalog-info.yaml #568

Closed
robrap opened this issue Mar 5, 2024 · 6 comments
Closed

Clarify the options for icon in catalog-info.yaml #568

robrap opened this issue Mar 5, 2024 · 6 comments
Assignees

Comments

@robrap
Copy link
Contributor

robrap commented Mar 5, 2024

The use of icon should be clarified in the docs for catalog-info.yaml:
https://github.com/openedx/open-edx-proposals/edit/master/oeps/processes/oep-0055/decisions/0001-use-backstage-to-support-maintainers.rst

The following list is very clear, it gives the acceptable type values:

# (Required) Acceptable Type Values: service, website, library
type: 'website'

Here are the current docs for icon:

# Backstage uses the MaterialUI Icon Set.
# https://mui.com/material-ui/material-icons/
# The value will be the name of the icon.
icon: "Web"

What it would be useful to know is:

  1. Do we simply want to use "Web" for everything, do we want to give users a small enumerated list, or do we allow choosing from anything in the icon set?
  2. Do we want to use 3 standard icons that match the type values of service, website, or library?
  3. Do we want other icons to be used? If so, under what circumstances?
@robrap
Copy link
Contributor Author

robrap commented Mar 5, 2024

@feanil: I should probably open a separate ticket, but I just noticed that the proposed type for https://github.com/openedx/edx-repo-health is 'other'. I think type needs at least one more value of other, or tool, or utility, or something of this nature. Thoughts?

@sarina sarina changed the title Can the instructions for icon in catalog-info.yaml be clarified? Clarify the options for icon in catalog-info.yaml May 17, 2024
@sarina
Copy link
Contributor

sarina commented May 17, 2024

@feanil could you provide any insight here? What would you like to see from this icon field?

@sarina sarina added the blocked by other work PR cannot be finished until other work is complete label May 17, 2024
@feanil
Copy link
Contributor

feanil commented May 20, 2024

I honestly have no opinion on what the value of Icon should be, it's meant to be representative of the link that it is associated with. The lack of guidance on the icon is because I don't think it needs guidance. I guess we could say that if you're not sure about what to choose, just choose the "Web" icon? Would that be helpful?

@sarina
Copy link
Contributor

sarina commented May 21, 2024

I've poked around backstage and I don't even see the use of this "web" icon:

image

anywhere. Do we need this field?

On the Search page I see an icon for "Software Catalog"

image

On the Home page I see no icons, and when I click in to a repo like https://backstage.openedx.org/catalog/default/component/openedx-learning i similarly don't see this icon.

@feanil
Copy link
Contributor

feanil commented May 21, 2024

The icon defines the bit highlighted in this image in red:
image

It's just for the specific link in the links list and not related to the rest of the backstage representation for a catalog resource.

@sarina
Copy link
Contributor

sarina commented May 21, 2024

Ah gotcha. That icon doesn't match the "Web" icon from https://mui.com/material-ui/material-icons/ so I missed it.

If the icon set Backstage uses doesn't even match the one that's linked, it'll be difficult to pick an appropriate alternate. I'm inclined to say we should just always use "Web".

@sarina sarina added in review and removed blocked by other work PR cannot be finished until other work is complete labels Jul 4, 2024
@sarina sarina closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants