Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: standardized button styling system in the app #410

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

refactor: standardized button styling system in the app #410

wants to merge 4 commits into from

Conversation

farhan-arshad-dev
Copy link
Contributor

@farhan-arshad-dev farhan-arshad-dev commented Nov 22, 2024 •
edited
Loading

Description

Standardized button styling system in the app

  • Define styling for button types (primary, secondary, tertiary, error, etc.) to make button styles configurable.
  • Update the button color scheme according to the Mobile App v2.3 [Open edX] button styles.

Samples

Before After
Screenshot_20241204_153214 Screenshot_20241204_153203
Screenshot_20241204_153350 Screenshot_20241204_153559
Screenshot_20241204_153749 Screenshot_20241204_153801

@farhan-arshad-dev
refactor: standardized styling button system in the app
c32053c 
- Define styling for buttons types (primary, secondary, tertiary, error, etc.) to make button styles configurable.

fixes: LEARNER-10140
@farhan-arshad-dev farhan-arshad-dev requested review from HamzaIsrar12 and omerhabib26 and removed request for HamzaIsrar12 November 22, 2024 05:30
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 22, 2024
View reviewed changes
core/src/main/java/org/openedx/core/ui/ComposeCommon.kt Fixed Show fixed Hide fixed
core/src/main/java/org/openedx/core/ui/ComposeCommon.kt Fixed Show fixed Hide fixed
core/src/main/java/org/openedx/core/ui/ComposeCommon.kt Fixed Show fixed Hide fixed
core/src/main/java/org/openedx/core/ui/ComposeCommon.kt Fixed Show fixed Hide fixed
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt Fixed Show fixed Hide fixed
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt Fixed Show fixed Hide fixed
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt Fixed Show fixed Hide fixed
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt Fixed Show fixed Hide fixed
@farhan-arshad-dev farhan-arshad-dev marked this pull request as draft November 22, 2024 05:33
@farhan-arshad-dev farhan-arshad-dev marked this pull request as ready for review December 4, 2024 10:39
@sdaitzman
Copy link

Hi @farhan-arshad-dev, these screenshots/contrast enhancements look great! It would be helpful to have more screenshots throughout the app for review, or ideally a build for testing against the proposed changes in Figma.

PavloNetrebchuk
PavloNetrebchuk approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhan-arshad-dev
Copy link
Contributor Author

Hi @sdaitzman, Apologies for the delay, I was occupied with some tasks.
Could you kindly provide the details for sharing the build?

@sdaitzman
Copy link

@farhan-arshad-dev sent on Slack, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavloNetrebchuk PavloNetrebchuk PavloNetrebchuk approved these changes

@omerhabib26 omerhabib26 Awaiting requested review from omerhabib26

@volodymyr-chekyrta volodymyr-chekyrta Awaiting requested review from volodymyr-chekyrta

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farhan-arshad-dev @sdaitzman @PavloNetrebchuk