Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash current must not be NaN during bulk download #412

Merged

Conversation

dixidroid
Copy link
Contributor

Description

LEARNER-10248

Fix crash of IllegalArgumentException - current must not be NaN during bulk download.

  • Add validation to ensure that the progress value is not NaN.

Steps to reproduce (specific courses)

Variant-1

  • Open the course named Quantum Mechanics for Scientists and Engineers 1
  • Click on the video tab and start that bulk download.
  • Try to expand the sections from the video tab, that lead the app to the crash.

Variant-2

  • Open the course named Quantum Mechanics for Scientists and Engineers 1
  • Click on the video tab and start that bulk download.
  • Rapidly click on the arrow icon to expand the section from the Home tab, and the action leads the app to the crash.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 26, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @dixidroid!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-mobile-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211
Copy link

Hi @dixidroid! Are you contributing as an individual, or on behalf of an organization?

@dixidroid
Copy link
Contributor Author

hi @mphilbrick211! I'm a 2U member and someone removed my email from the Edx organization. I've already created an issue here - openedx/axim-engineering#1317 but still waiting...not sure how long it will take.

@mphilbrick211
Copy link

Hi @dixidroid! You can have your manager reach out to oscm@axim.org as well. Your manager can ask that you be added to our existing 2U agreement.

@dixidroid dixidroid force-pushed the 2U/farhan_ar/LEARNER-10248 branch 2 times, most recently from 72bfbed to 614c586 Compare December 5, 2024 16:09
- Add validation to ensure that the progress value is not NaN.

fixes: LEARNER-10248
@dixidroid dixidroid force-pushed the 2U/farhan_ar/LEARNER-10248 branch from 614c586 to afa457c Compare December 5, 2024 16:10
@dixidroid
Copy link
Contributor Author

Hi @mphilbrick211! I was added to the edX org. Do you know how to rerun the openedx/cla check?

@mphilbrick211
Copy link

Hi @mphilbrick211! I was added to the edX org. Do you know how to rerun the openedx/cla check?

@dixidroid - you should be able to re-run them and the CLA check should turn green. If you try again and it's not working, let me know!

@volodymyr-chekyrta volodymyr-chekyrta merged commit 46c32a2 into openedx:develop Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants