test: Automatically discover new signals.py files in tests #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This will ensure that when new signals are added in new domains, they'll be picked up by the tests. There's still a hardcoded list, but it's just there to ensure there aren't silent regressions.
timmc-edx
force-pushed
the
timmc/autodetect-signal
branch
from
ff0286c to
c7c8846
Compare
timmc-edx
commented
Feb 3, 2023
| for m in pkgutil.walk_packages(root.__path__, root.__name__ + '.'): | ||
| module_name = m.name | ||
| if 'tests' in module_name.split('.') or '.test_' in module_name: | ||
| continue |
There was a problem hiding this comment.
I don't actually care about coverage here, but it's weird that this line is allegedly not covered. There should be about 10 test modules that hit this line during the walk, and I see them locally if I put a print statement here!
There was a problem hiding this comment.
This is because Python has optimized away that line: nedbat/coveragepy#198
mariajgrimaldi
pushed a commit
that referenced
this pull request
Feb 15, 2023
This will ensure that when new signals are added in new domains, they'll be picked up by the tests. There's still a hardcoded list, but it's just there to ensure there aren't silent regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that when new signals are added in new domains, they'll be picked up by the tests. There's still a hardcoded list, but it's just there to ensure there aren't silent regressions.
Merge checklist: