Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the tests' inclusion in the plugin #82

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Jun 25, 2024

Description

This PR removes the inclusion of the test as a dependency for the plugin and also changes the composer.json to map and autoload the test only in dev mode.

Context
We removed the addition of test files in a production plugin in #76, which generated problems because the test module was included in class-openedx-commerce.php. Problem: #62 (comment)

Testing instructions

  1. Download this plugin with these changes: ZIP version, that was generated by this workflow.

  2. Install and activate the plugin in a clean WordPress instance (E. g., You can use Docker or Local)

If you want to go further, you can configure the plugin and test other functions.

Additional information

The URL of the zip file I created for testing this PR has the tag v2.0.3, but it is irrelevant because the workflow uploads the zip file in the latest release of my repo which is using this updated branch.
Ref

Video demo (Using Local)

Installing and activating the plugin in a clean installation
https://github.com/openedx/openedx-wordpress-ecommerce/assets/35668326/e9fb881a-8095-473e-a6b4-6ce1a2acc3bb

Checklist for Merge

  • Tested in a remote environment (clean and existent env)
  • Rebased master/main
  • Squashed commits

@openedx-webhooks
Copy link

openedx-webhooks commented Jun 25, 2024

Thanks for the pull request, @MaferMazu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 25, 2024
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look correct to me. Is what I would expect to solve the reported issue.

I downloaded the linked plugin package and it installs succesfully.

@MaferMazu
Copy link
Contributor Author

I'll merge this and run the action to generate the ZIP in release 2.0.4 (because the first one wasn't working correctly for the issue this PR is solving).

@MaferMazu MaferMazu merged commit e97fc8a into openedx:main Jun 26, 2024
4 checks passed
@openedx-webhooks
Copy link

@MaferMazu 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants