feat(modal): refactor modal to use portals #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arizzitano
commented
Dec 11, 2017
| outline-color: Highlight; | ||
| outline: -webkit-focus-ring-color auto 5px; | ||
| } | ||
| } |
There was a problem hiding this comment.
The upstream patch for this merged!
arizzitano
commented
Dec 11, 2017
| if (!modalRoot) { | ||
| modalRoot = document.createElement('div'); | ||
| modalRoot.id = modalRootId; | ||
| document.body.appendChild(modalRoot); |
There was a problem hiding this comment.
This doesn't feel quite right to me but I can't think of a low-API way to ensure the element exists in the DOM, outside the bounds of this component.
|
Test failures are due to enzymejs/enzyme#1150, which looks pretty hairy tbh. |
arizzitano
changed the title
arizzitano
force-pushed
the
ari/portal-modal
branch
from
9fef2bf
to
1c3f0f0
Compare
arizzitano
commented
Dec 18, 2017
| @@ -1,3 +1,5 @@ | |||
| import initStoryshots from '@storybook/addon-storyshots'; | |||
|
|
|||
| initStoryshots(); | |||
| initStoryshots({ | |||
| storyKindRegex:/^((?!.*?Modal).)*$/ | |||
There was a problem hiding this comment.
I can't figure out how to make storyshots generate the modal snapshots without throwing, so I just skipped them for now. I don't think it negatively affects coverage.
There was a problem hiding this comment.
JK it does. Looking into it.
arizzitano
force-pushed
the
ari/portal-modal
branch
from
742f3b4
to
15f7042
Compare
|
way out of date; closing in favor of @Mjloturco's (eventual) better solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Modal to render its element to a portal at the root of
document.body. This:TODO