Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Pull Request] feat: Support web-based LMS OAuth #345

Closed
1 task
jmakowski1123 opened this issue Mar 28, 2024 · 11 comments
Closed
1 task

[Product Pull Request] feat: Support web-based LMS OAuth #345

jmakowski1123 opened this issue Mar 28, 2024 · 11 comments
Assignees

Comments

@jmakowski1123
Copy link

Master ticket for the project.

Child PRs:

@jmakowski1123 jmakowski1123 converted this from a draft issue Mar 28, 2024
@jmakowski1123 jmakowski1123 self-assigned this Mar 28, 2024
Copy link

Thanks for your submission, @openedx/open-edx-project-managers will review shortly.

@jmakowski1123 jmakowski1123 moved this to Roadmap Feature Tickets (Product) in Contributions Mar 28, 2024
@jmakowski1123 jmakowski1123 moved this from [Prod Proposals] In Review to Backlog in Open edX Roadmap Apr 8, 2024
@itsjeyd
Copy link

itsjeyd commented Apr 25, 2024

@xitij2000 @Kelketek If I understand correctly (?), openedx/openedx-app-android#190 is closely related to openedx/openedx-app-ios#65, the only PR listed as a child of this roadmap item so far.

Would it make sense to add openedx/openedx-app-android#190 to the list above?

CC @jmakowski1123

@xitij2000
Copy link

@xitij2000 @Kelketek If I understand correctly (?), openedx/openedx-app-android#190 is closely related to openedx/openedx-app-ios#65, the only PR listed as a child of this roadmap item so far.

Would it make sense to add openedx/openedx-app-android#190 to the list above?

CC @jmakowski1123

Yes, I think that is the latest version of the "login-via-LMS" work.

@mphilbrick211
Copy link

Hi all, just looking for an update here (@jmakowski1123)

@Kelketek
Copy link

@mphilbrick211 The sponsoring organization decided not to move this forward to completion, unfortunately, so it's stuck.

@itsjeyd
Copy link

itsjeyd commented Aug 1, 2024

@Kelketek @mphilbrick211 For openedx/openedx-app-android#190 specifically, I think we might actually have a way forward.

@xitij2000 Does the new PR that you created a couple days ago (openedx/openedx-app-android#371) fully replace that PR?

@xitij2000
Copy link

@itsjeyd Yes, I should perhaps have updated the same PR, however, this one is the same code rebased to the latest main branch.

@itsjeyd
Copy link

itsjeyd commented Aug 6, 2024

@xitij2000 OK, thanks for confirming 👍

@mphilbrick211 @jmakowski1123 Could we get openedx/openedx-app-android#371 added to the list of child PRs for this feature ticket in the description above?

CC @Kelketek

@mphilbrick211
Copy link

Is there an update on this?

@Kelketek
Copy link

@mphilbrick211 The Android feature has apparently been merged, but I haven't gotten confirmation on it for the iOS app.

@jmakowski1123 jmakowski1123 moved this from Backlog - Is resourced to Shipped in Open edX Roadmap Dec 16, 2024
@jmakowski1123 jmakowski1123 closed this as completed by moving to Shipped in Open edX Roadmap Dec 16, 2024
@github-project-automation github-project-automation bot moved this from Roadmap Feature Tickets (Product) to Done in Contributions Dec 16, 2024
@github-project-automation github-project-automation bot moved this from Shipped to Abandoned in Open edX Roadmap Dec 16, 2024
@Kelketek
Copy link

@jmakowski1123 Did you mean to close this ticket? Android got this feature but I don't think iOS did. The PR on this ticket hasn't been merged either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Abandoned
Development

No branches or pull requests

5 participants