Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-1998 Update test runner and dependency management #26

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

jmbowman
Copy link
Contributor

@jmbowman jmbowman commented Mar 5, 2018

The tests weren't running under Django 1.11 and there wasn't a good mechanism for testing support of multiple Django versions, so I made a few updates based on what we're now doing in other edX packages:

  • Manage dependencies with pip-tools
  • Switched from nosedjango to pytest as the test runner
  • Added support for using tox to test against multiple Django versions in Travis

I also laid the groundwork for linting import order with isort and checking for Python 3 compatibility issues, but am leaving those disabled so the changes needed to make them pass can be tackled in future PRs. .pylintrc should also be updated via edx-lint later in a separate PR which also fixes any new issues reported by doing that.

@jmbowman jmbowman force-pushed the jmbowman/PLAT-1998 branch 6 times, most recently from 7dd29a5 to 9ccbddc Compare March 5, 2018 21:49
@jmbowman jmbowman force-pushed the jmbowman/PLAT-1998 branch from 9ccbddc to aa3afbc Compare March 5, 2018 21:53
Copy link

@doctoryes doctoryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be easier to shift this repo over to the edx org if we uploaded the wheel to PyPI and started using that pkg in edx-platform. Is that out-of-scope of this PR?

@jmbowman
Copy link
Contributor Author

jmbowman commented Mar 7, 2018

@doctoryes Not sure. That path would require us to update the URL in setup.py after the initial release, but that may not be a problem. At any rate, I probably won't have time to tackle it before I head out on PTO tomorrow.

@doctoryes
Copy link

@jmbowman Probably won't be a problem - I forgot that GitHub redirects if you transfer a repo between users/orgs.

@jmbowman jmbowman merged commit 1efbb08 into openedx:master Mar 29, 2018
@jmbowman jmbowman deleted the jmbowman/PLAT-1998 branch March 29, 2018 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants