Upgrade to python 3. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated travis.yml to run tests on both python 2 and 3, added openedx.yaml. PROD-773
Image url used to test Image rendering was returing 404 (Gone)
|
@feanil Please review this PR. |
feanil
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
@waheedahmed generally looks good, just looking for some more info/comments and then I think this is good to merge.
|
Sorry for the delay on merging -- thanks for the work here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated travis.yml to run tests on both python 2 and 3, added openedx.yaml.
PROD-773