Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove bok-choy usage #66

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

salman2013
Copy link
Contributor

Description

As the bok-choy has been deprecated openedx/public-engineering#13, we are removing its usage from the code in this PR.

Ticket : https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=40721600

- name: Install Requirements
run: |
pip install -r requirements/ci.txt

- name: Run Tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will stop running all environments of tox test cases. Try following

      - name: Run Tests
        run: tox -e ${{ matrix.toxenv }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhan it did not affect, I found there is some issue due to which ci.yml is not executing even in some past PRs, I am creating a separate issue so that we can properly find the reason to fix it.
https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=42628017

@salman2013 salman2013 requested a review from farhan October 25, 2023 09:43
@salman2013 salman2013 force-pushed the salman/remove-bok-choy branch from 3fa3a5d to cdf6c0c Compare October 25, 2023 11:57
@feanil feanil merged commit fdd2cb4 into openedx:master Oct 25, 2023
1 check passed
@feanil feanil mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants