Replaced whitelist_externals with allowlist_externals in tox and removed tox-battery #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
approved these changes
Oct 31, 2023
|
@feanil would it be okay if we merge this PR with the test failures since the failures are not related to the changes made in the PR. |
|
@UsamaSadiq #68 resolves the issue on master, let's merge that first and then you can merge this one after a rebase. |
|
@zubairshakoorarbisoft could you try rebasing the PR. The errors should be resolved now. |
UsamaSadiq
force-pushed
the
zshkoor/tox-updates
branch
from
b169025 to
44522d8
Compare
UsamaSadiq
force-pushed
the
zshkoor/tox-updates
branch
from
44522d8 to
96d0ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: edx/edx-arch-experiments#130