Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Hide token balance when syncing #269

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Hide token balance when syncing #269

merged 2 commits into from
Nov 26, 2018

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Nov 23, 2018

  • Fix Show overlay on tokenlist when syncing #268 (I start slow for one of my 1st PR :) )
  • Should I remove the requireHealth from TxForm? I though that if for some reason the client looses the sync while the user is on this form, it wouldn't be bad to have an overlay.
  • It looks like the linter from my editor added a 0 in front of the .8.. let me know if I should remove it.

@amaury1093
Copy link
Collaborator

Nice! Code looks good, though I wasn't able to test because of #273.

axelchalon
axelchalon approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@axelchalon axelchalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! code LGTM; works fine!

@Tbaut Tbaut merged commit 57efe14 into master Nov 26, 2018
@Tbaut Tbaut deleted the tbaut-overlay-balances branch November 26, 2018 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@axelchalon axelchalon axelchalon approved these changes

@amaury1093 amaury1093 Awaiting requested review from amaury1093

Assignees
No one assigned
Labels
A0-pleasereview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tbaut @amaury1093 @axelchalon