Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

feat: Delete account #528

Merged
merged 5 commits into from
Jun 5, 2019
Merged

feat: Delete account #528

merged 5 commits into from
Jun 5, 2019

Conversation

amaury1093
Copy link
Collaborator

fixes #448

Unfortunately I didn't add German translations. I can deepl them, but not sure it's the best

Copy link
Contributor

@axelchalon axelchalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well & code lgtm!

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit.
Works well (also tested with a Signer account)

packages/fether-react/src/i18n/locales/en.json Outdated Show resolved Hide resolved
Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@Tbaut
Copy link
Collaborator

Tbaut commented Jun 5, 2019

I'll commit the german translation directly if you're ok. It might not be perfect, but better than nothing.

@amaury1093
Copy link
Collaborator Author

Sure, it'll be much simpler like this

@amaury1093 amaury1093 merged commit 929ed29 into master Jun 5, 2019
@amaury1093 amaury1093 deleted the am-delete branch June 5, 2019 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to remove accounts from wallet
3 participants