Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Parity no longer compatible with expanse #7061

Closed
wariner84 opened this issue Nov 15, 2017 · 14 comments
Closed

Parity no longer compatible with expanse #7061

wariner84 opened this issue Nov 15, 2017 · 14 comments
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M2-config 📂 Chain specifications and node configurations. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone

Comments

@wariner84
Copy link

wariner84 commented Nov 15, 2017

Parity (1.8.2) is no longer compatible with expanse, since it is working on the wrong chain. Expanse forked at block 800’000.

@5chdn
Copy link
Contributor

5chdn commented Nov 15, 2017

Is expanse no longer maintaining parity compatibility?

We should consider removing it then.

@5chdn 5chdn added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M2-config 📂 Chain specifications and node configurations. P7-nicetohave 🐕 Issue is worth doing eventually. labels Nov 15, 2017
@5chdn 5chdn added this to the 1.10 milestone Nov 15, 2017
@rphmeier
Copy link
Contributor

@5chdn is right. we only maintain specs for most chains up to the point that the developers for those chains are willing to maintain them

@5chdn
Copy link
Contributor

5chdn commented Nov 22, 2017

Found the changes in here: https://github.com/expanse-org/go-expanse/releases/tag/v1.7.2

Expanse Changes 1.7.2

  • Upgrade Objectives:
  • Upgrade EXP to the latest ETH:Byzantium protocol.
  • Make EXP transactions faster
  • Decrease uncle inflation
  • Maintain Block Reward 8/min

Byzantium Objectives:

  • Addition of ‘REVERT’ opcode, which permits error handling without consuming all gas (EIP 140)
  • Transaction receipts now include a status field to indicate success or failure EIP 658)
  • Elliptic curve addition and scalar multiplication on alt_bn128 (EIP 196) and pairing checks (EIP 197), permitting
  • ZK-Snarks and other cryptographic mathemagic™
  • Support for big integer modular exponentiation (EIP 198), enabling RSA signature verification and other cryptographic applications
  • Support for variable length return values (EIP 211)
  • Addition of the ‘STATICCALL’ opcode, permitting non-state-changing calls to other contracts (EIP 214)
  • Changes to the difficulty adjustment formula to take uncles into account (EIP 100)

Important Information:

  • Fork Block Number: 800,000
  • New Block Target: 30 Seconds
  • New Block Reward: 4 EXP

Friendly ping to EXP dev @chrisfranko - could you comment on this? Is EXP support in Parity still desired? :)

@chrisfranko
Copy link
Contributor

Yes we would still love parity support. When making the fork I didnt see where to make the corresponding changes to parity to submit the pr. If you could kindly point me to where i can make the Byzantium changes that would be awesome!

@5chdn
Copy link
Contributor

5chdn commented Nov 23, 2017

I think most of the changes can be applied by adjusting the chain spec in

https://github.com/paritytech/parity/blob/master/ethcore/res/ethereum/expanse.json

I'm not quite understanding the complexity of the changes involved. Did you just enable Byzantium? Is the block target time and reward related to EIP649?

If yes, you can use eip649transition and reward, compare: 07c63c1

I'm happy to test if you come up with a chain spec. If there is anything on top of this, it might require additional code.

@chrisfranko
Copy link
Contributor

Thanks 5chdn ill do this first thing in the AM, holliday stuff had me busy this weekend. ^_^

@Serpent6877
Copy link

Any news on this? What happens to the coins that were mined after the fork on the old chain using Parity?

@5chdn
Copy link
Contributor

5chdn commented Jan 2, 2018

No idea. You can start Expanse Classic 😛

Closing as there is nobody maintaining this anymore.

@bjornwgnr
Copy link
Collaborator

@chrisfranko FYI ^

@5chdn
Copy link
Contributor

5chdn commented Jan 3, 2018

Happy to accept a PR with a working integration. For now it's urgent to remove it to avoid users getting stuck on the wrong fork.

@chrisfranko
Copy link
Contributor

Except there is someone maintaining it and we were waiting on guidance because we updated everything we thought we were supposed to update.

@5chdn
Copy link
Contributor

5chdn commented Jan 3, 2018

I'm sorry if this was due to a misunderstanding. Let's keep working on #7146 and I'll try to guide you.

@chrisfranko
Copy link
Contributor

chrisfranko commented Jan 4, 2018 via email

@chrisfranko
Copy link
Contributor

chrisfranko commented Jan 4, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M2-config 📂 Chain specifications and node configurations. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

6 participants