Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Export blocks crashes without specifying output #7486

Closed
nicksavers opened this issue Jan 7, 2018 · 0 comments · Fixed by #7495
Closed

Export blocks crashes without specifying output #7486

nicksavers opened this issue Jan 7, 2018 · 0 comments · Fixed by #7495
Labels
F2-bug 🐞 The client fails to follow expected behavior.
Milestone
1.9 Velocity

Comments

@nicksavers
Copy link

I'm running:

Parity version?: v1.8.5-beta-54bae9a-20171228/x86_64-windows-msvc/rustc1.22.1
Operating system?: Windows
Installed?: via installer
Fully synchronized?: yes

When running parity.exe export blocks --from 0 --to 4860000, I expected a process to start running. Instead the process crashed.

2018-01-07 03:23:59  Configured for Foundation using Ethash engine
2018-01-07 03:24:00  #0

====================

stack backtrace:
   0:     0x7ff62bc54612 - hid_error
   1:     0x7ff62bc54af3 - hid_error
   2:     0x7ff62b48b634 - <no info>
   3:     0x7ff62bdc50e4 - hid_error
   4:     0x7ff62bdc4f59 - hid_error
   5:     0x7ff62bdc4e32 - hid_error
   6:     0x7ff62bdc4da0 - hid_error
   7:     0x7ff62bdce39f - hid_error
   8:     0x7ff62b055e58 - <no info>
   9:     0x7ff62b1e0f8b - <no info>
  10:     0x7ff62b25e0ae - <no info>
  11:     0x7ff62b26353a - <no info>
  12:     0x7ff62b266a87 - <no info>
  13:     0x7ff62bdc6572 - hid_error
  14:     0x7ff62bdc58e2 - hid_error
  15:     0x7ff62bfc0279 - hid_write
  16:     0x7ff9bb331fe4 - BaseThreadInitThunk

Thread 'main' panicked at 'Couldn't write to stream.: Error { repr: Custom(Custom { kind: InvalidData, error: StringError("text was not valid unicode") }) }', src\libcore\result.rs:906

Only when specifying an output file parity.exe export blocks --from 0 --to 4860000 > myexport.bin the process runs as intended. A warning message instead of a crash would be nice.
@debris debris added the F2-bug 🐞 The client fails to follow expected behavior. label Jan 8, 2018
debris added a commit that referenced this issue Jan 8, 2018
@debris
fixed panic when io is not available for export block, closes #7486
3e27c7f
@debris debris mentioned this issue Jan 8, 2018
Merged
tomusdrw pushed a commit that referenced this issue Jan 8, 2018
@debris @tomusdrw
fixed panic when io is not available for export block, closes #7486 (#…
7316cb9 
…7495)
tomusdrw pushed a commit that referenced this issue Jan 8, 2018
@debris @tomusdrw
fixed panic when io is not available for export block, closes #7486 (#…
b8d6ed6 
…7495)
debris added a commit that referenced this issue Jan 8, 2018
@debris
fixed panic when io is not available for export block, closes #7486 (#…
ddf6066 
…7495)
5chdn pushed a commit that referenced this issue Jan 8, 2018
@tomusdrw @5chdn
[stable] backports (#7496)
e192501 
* Advance AuRa step as far as we can.

* fixed panic when io is not available for export block, closes #7486 (#7495)

* Update Parity Mainnet Bootnodes

* Replace the Azure HDD bootnodes with the new ones :)

* Bump version.
5chdn pushed a commit that referenced this issue Jan 9, 2018
@debris @5chdn
backports to beta (#7434)
a257827 
* Merge pull request #7368 from paritytech/td-future-blocks

Wait for future blocks in AuRa

* Fix tracing failed calls.

* Problem: sending any Whisper message fails

The error is "PoW too low to compete with other messages"

This has been previously reported in #7144

Solution: prevent the move semantics

The source of the error is in PoolHandle.relay
implementation for NetPoolHandle.

Because of the move semantics, `res` variable is in fact
copied (as it implements Copy) into the closure and for
that reason, the returned result is always `false.

* Merge pull request #7433 from paritytech/td-strict-config

Strict config parsing

* Problem: AuRa's unsafeties around step duration (#7282)

Firstly, `Step.duration_remaining` casts it to u32, unnecesarily
limiting it to 2^32. While theoretically this is "good enough" (at 3
seconds steps it provides room for a little over 400 years), it is
still a lossy way to calculate the remaining time until the next step.

Secondly, step duration might be zero, triggering division by zero
in `Step.calibrate`

Solution: rework the code around the fact that duration is
typically in single digits and never grows, hence, it can be represented
by a much narrower range (u16) and this highlights the fact that
multiplying u64 by u16 will only result in an overflow in even further
future, at which point we should panic informatively (if anybody's
still around)

Similarly, panic when it is detected that incrementing the step
counter wrapped around on the overflow of usize.

As for the division by zero, prevent it by making zero an invalid
value for step duration. This will make AuRa log the constraint
mismatch and panic (after all, what purpose would zero step duration
serve? it makes no sense within the definition of the protocol,
as finality can only be achieved as per the specification
if messages are received within the step duration, which would violate
the speed of light and other physical laws in this case).

* Merge pull request #7437 from paritytech/a5-chains-expanse

Remove expanse chain

* Expanse Byzantium update w/ correct metropolis difficulty increment divisor (#7463)

* Byzantium Update for Expanse

Here the changes go. Hope I didnt miss anything.

* expip2 changes - update duration limit

* Fix missing EXPIP-2 fields

* Format numbers as hex

* Fix compilation errors

* Group expanse chain spec fields together

* Set metropolisDifficultyIncrementDivisor for Expanse

* Revert #7437

* Add Expanse block 900_000 hash checkpoint

* Advance AuRa step as far as we can and prevent invalid blocks. (#7451)

* Advance AuRa step as far as we can.

* Wait for future blocks.

* fixed panic when io is not available for export block, closes #7486 (#7495)

* Update Parity Mainnet Bootnodes (#7476)

* Update Parity Mainnet Bootnodes

* Replace the Azure HDD bootnodes with the new ones :)

* Use https connection (#7503)

Use https when connecting to etherscan.io API for price-info

* Expose default gas price percentile configuration in CLI (#7497)

* Expose gas price percentile.

* Fix light eth_call.

* fix gas_price in light client
@5chdn 5chdn added this to the 1.9 milestone Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F2-bug 🐞 The client fails to follow expected behavior.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging a pull request may close this issue.

fixed panic when io is not available for export block openethereum/parity-ethereum
3 participants
@debris @nicksavers @5chdn