Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Implement EIP-1283 reenable transition, EIP-1706 and EIP-2200 #10191

Merged
merged 7 commits into from
Aug 29, 2019
Merged

Conversation

sorpaas
Copy link
Collaborator

@sorpaas sorpaas commented Jan 16, 2019

Reentry protection for EIP-1283, described in ethereum/EIPs#1706. With eip1884_transition this also implements EIP-2200.

Note that the correct way to enable this on Ethereum mainnet would be to set both eip1283_reenable_transition and eip1706_transition.

@sorpaas sorpaas added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. M4-core ⛓ Core client code / Rust. labels Jan 16, 2019
@sorpaas sorpaas added this to the 2.4 milestone Jan 16, 2019
@sorpaas sorpaas closed this Jan 18, 2019
@sorpaas sorpaas deleted the sp-sstore branch January 18, 2019 15:30
@sorpaas sorpaas restored the sp-sstore branch January 18, 2019 15:38
@sorpaas sorpaas reopened this Jan 18, 2019
@sorpaas sorpaas added A0-pleasereview 🤓 Pull request needs code review. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Jan 18, 2019
@5chdn 5chdn added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jan 19, 2019
@5chdn
Copy link
Contributor

5chdn commented Jan 19, 2019

Putting this on ice because, ideally, we want to only implement EIPs that are accepted or we are really certain we want to further diverge from mainnet. I'd say, let's disable 1283 on kovan for now.

@5chdn 5chdn removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Feb 7, 2019
@5chdn
Copy link
Contributor

5chdn commented Feb 7, 2019

I'm down to accept this.

@ddorgan ddorgan closed this Feb 7, 2019
@ddorgan ddorgan reopened this Feb 7, 2019
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 7, 2019
@5chdn 5chdn modified the milestones: 2.4, 2.5, 2.6 Feb 21, 2019
@sorpaas sorpaas added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 29, 2019
@sorpaas sorpaas added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Aug 29, 2019
@ordian ordian modified the milestones: 2.5, 2.7 Aug 29, 2019
@ordian ordian added B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. B1-patch-beta 🕷🕷 labels Aug 29, 2019
@sorpaas sorpaas changed the title Add reentry protection for EIP-1283 Implement EIP-1283 reenable transition, EIP-1706 and EIP-2200 Aug 29, 2019
@sorpaas sorpaas added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. A0-pleasereview 🤓 Pull request needs code review. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. A0-pleasereview 🤓 Pull request needs code review. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Aug 29, 2019
@sorpaas sorpaas merged commit 00124b5 into master Aug 29, 2019
@sorpaas sorpaas deleted the sp-sstore branch August 29, 2019 19:31
ordian added a commit to ordian/parity that referenced this pull request Aug 30, 2019
* master:
  Implement EIP-1283 reenable transition, EIP-1706 and EIP-2200 (openethereum#10191)
dvdplm added a commit that referenced this pull request Sep 2, 2019
* master:
  EIP 1108: Reduce alt_bn128 precompile gas costs (#11008)
  Fix deadlock in `network-devp2p` (#11013)
  Implement EIP-1283 reenable transition, EIP-1706 and EIP-2200 (#10191)
dvdplm added a commit that referenced this pull request Sep 3, 2019
…he-right-place

* master:
  Extract snapshot to own crate (#11010)
  Edit publish-onchain.sh to use https (#11016)
  EIP 1108: Reduce alt_bn128 precompile gas costs (#11008)
  Fix deadlock in `network-devp2p` (#11013)
  Implement EIP-1283 reenable transition, EIP-1706 and EIP-2200 (#10191)
  EIP 1884 Re-pricing of trie-size dependent operations (#10992)
s3krit pushed a commit that referenced this pull request Sep 13, 2019
* Add reentry protection for EIP-1283

* typo: should use <=

* Put things behind flag eip1706

* Fix compile

* Fix missing config in json and add eip1283_reenable_transition
s3krit pushed a commit that referenced this pull request Sep 13, 2019
* Add reentry protection for EIP-1283

* typo: should use <=

* Put things behind flag eip1706

* Fix compile

* Fix missing config in json and add eip1283_reenable_transition
s3krit pushed a commit that referenced this pull request Sep 13, 2019
* Add reentry protection for EIP-1283

* typo: should use <=

* Put things behind flag eip1706

* Fix compile

* Fix missing config in json and add eip1283_reenable_transition
@s3krit s3krit mentioned this pull request Sep 13, 2019
s3krit pushed a commit that referenced this pull request Sep 13, 2019
* Add reentry protection for EIP-1283

* typo: should use <=

* Put things behind flag eip1706

* Fix compile

* Fix missing config in json and add eip1283_reenable_transition
@s3krit s3krit mentioned this pull request Sep 13, 2019
s3krit added a commit that referenced this pull request Sep 13, 2019
* EIP 1884 Re-pricing of trie-size dependent operations  (#10992)
* Implement EIP-1283 reenable transition, EIP-1706 and EIP-2200  (#10191)
s3krit added a commit that referenced this pull request Sep 13, 2019
* EIP 1884 Re-pricing of trie-size dependent operations  (#10992)
* Implement EIP-1283 reenable transition, EIP-1706 and EIP-2200  (#10191)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants