Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Clique: zero-fill extradata when the supplied value is less than 32 bytes in length #10605

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

jwasinger
Copy link
Contributor

@jwasinger jwasinger commented Apr 22, 2019

Attempt at a fix for #10603 . haven't verified yet.

@parity-cla-bot
Copy link

It looks like @jwasinger signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Apr 23, 2019
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm quite confident that this will fix #10603 but please let us know when you have verified that!

@niklasad1 niklasad1 added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 23, 2019
@jwasinger
Copy link
Contributor Author

Verified locally that it solves #10603

@jam10o-new jam10o-new added A8-looksgood 🦄 Pull request is reviewed well. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Apr 29, 2019
@niklasad1 niklasad1 removed the A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. label Apr 29, 2019
@HCastano HCastano merged commit 64fd64f into openethereum:master Apr 29, 2019
soc1c pushed a commit that referenced this pull request May 10, 2019
@soc1c soc1c mentioned this pull request May 10, 2019
9 tasks
soc1c added a commit that referenced this pull request May 10, 2019
* version: bump beta to 2.5.1

* fix(whisper expiry): current time + work + ttl (#10587)

* update bootnodes (#10595)

* config: update goerli bootnodes

* config: update kotti bootnodes

* adds rpc error message for --no-ancient-blocks (#10608)

* adds error message for --no-ancient-blocks, closes #10261

* Apply suggestions from code review

Co-Authored-By: seunlanlege <seunlanlege@gmail.com>

* Constantinople HF on POA Core (#10606)

* Constantinople HF on POA Core

Plan Constantinople/St.Petersfork HF on POA Core network at block 8582254.
Original PR in POA repository: poanetwork/poa-chain-spec#110

* Remove extra empty line

* evm: add some mulmod benches (#10600)

* evm: add blockhash_mulmod bench

* evm: use num-bigint for mod ops

* Clique: zero-fill extradata when the supplied value is less than 32 bytes in length (#10605)

* Update kovan.json to switch validator set to POA Consensus Contracts (#10628)

* Fix publish docs (#10635)

* Fix publish docs

* this never should be forced, either way compiling previous versions will produce outdated docs

* fix array, var was moved to the group project global variables list

* Fix rinkeby petersburg fork (#10632)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants