This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Clique: zero-fill extradata when the supplied value is less than 32 bytes in length #10605
Merged
HCastano
merged 1 commit into
openethereum:master
from
jwasinger:clique-extra-data-zerofill
Apr 29, 2019
Merged
Clique: zero-fill extradata when the supplied value is less than 32 bytes in length #10605
HCastano
merged 1 commit into
openethereum:master
from
jwasinger:clique-extra-data-zerofill
Apr 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like @jwasinger signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
niklasad1
reviewed
Apr 23, 2019
niklasad1
added
A0-pleasereview 🤓
Pull request needs code review.
M4-core ⛓
Core client code / Rust.
labels
Apr 23, 2019
niklasad1
reviewed
Apr 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm quite confident that this will fix #10603 but please let us know when you have verified that!
niklasad1
added
A1-onice 🌨
Pull request is reviewed well, but should not yet be merged.
A6-mustntgrumble 💦
Pull request has areas for improvement. The author need not address them before merging.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Apr 23, 2019
jwasinger
force-pushed
the
clique-extra-data-zerofill
branch
from
April 29, 2019 05:43
a1cd46d
to
36206eb
Compare
Verified locally that it solves #10603 |
jam10o-new
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A1-onice 🌨
Pull request is reviewed well, but should not yet be merged.
labels
Apr 29, 2019
niklasad1
approved these changes
Apr 29, 2019
niklasad1
removed
the
A6-mustntgrumble 💦
Pull request has areas for improvement. The author need not address them before merging.
label
Apr 29, 2019
HCastano
approved these changes
Apr 29, 2019
soc1c
pushed a commit
that referenced
this pull request
May 10, 2019
soc1c
added a commit
that referenced
this pull request
May 10, 2019
* version: bump beta to 2.5.1 * fix(whisper expiry): current time + work + ttl (#10587) * update bootnodes (#10595) * config: update goerli bootnodes * config: update kotti bootnodes * adds rpc error message for --no-ancient-blocks (#10608) * adds error message for --no-ancient-blocks, closes #10261 * Apply suggestions from code review Co-Authored-By: seunlanlege <seunlanlege@gmail.com> * Constantinople HF on POA Core (#10606) * Constantinople HF on POA Core Plan Constantinople/St.Petersfork HF on POA Core network at block 8582254. Original PR in POA repository: poanetwork/poa-chain-spec#110 * Remove extra empty line * evm: add some mulmod benches (#10600) * evm: add blockhash_mulmod bench * evm: use num-bigint for mod ops * Clique: zero-fill extradata when the supplied value is less than 32 bytes in length (#10605) * Update kovan.json to switch validator set to POA Consensus Contracts (#10628) * Fix publish docs (#10635) * Fix publish docs * this never should be forced, either way compiling previous versions will produce outdated docs * fix array, var was moved to the group project global variables list * Fix rinkeby petersburg fork (#10632)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at a fix for #10603 . haven't verified yet.