This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Upgrade ethereum types #10670
Merged
Upgrade ethereum types #10670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: docs: Add ProgPoW Rust docs to ethash module (#10653) fix: Move PR template into .github/ folder (#10663) docs: Add PR template (#10654) Trivial journal for private transactions (#10056) fix(compilation warnings) (#10649) [whisper] Move needed aes_gcm crypto in-crate (#10647) Adds parity_getRawBlockByNumber, parity_submitRawBlock (#10609) Fix rinkeby petersburg fork (#10632) ci: publish docs debug (#10638)
ordian
added
A0-pleasereview 🤓
dvdplm
reviewed
May 17, 2019
| @@ -157,7 +157,12 @@ impl DatabaseDirectories { | |||
| /// Base DB directory for the given fork. | |||
| // TODO: remove in 1.7 | |||
There was a problem hiding this comment.
This is an interesting comment. Still relevant?
ordian
commented
May 17, 2019
ordian
commented
May 29, 2019
| 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, | ||
| 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xfe, | ||
| 0xba, 0xae, 0xdc, 0xe6, 0xaf, 0x48, 0xa0, 0x3b, | ||
| 0xbf, 0xd2, 0x5e, 0x8c, 0xd0, 0x36, 0x41, 0x41, |
There was a problem hiding this comment.
I've changed some bytes here to see if tests fail, but sadly, there were no test to catch that.
Co-Authored-By: David <dvdplm@gmail.com>
ordian
added
the
A1-onice 🌨
|
Putting on ice till ethabi 8.0.0 is published to avoid accidental merge. |
ordian
removed
the
A1-onice 🌨
dvdplm
added a commit
that referenced
this pull request
Jun 3, 2019
* master: Upgrade ethereum types (#10670)
dvdplm
added a commit
that referenced
this pull request
Jun 3, 2019
…ypto-from-devp2p * dp/chore/devp2p-cosmetics: Reorg imports Upgrade ethereum types (#10670)
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've accumulated technical debt by not upgrading
ethereum-typesand other related dependencies.This PR tries to fix that to take advantage of recent improvements introduced in the
uintcrate.Unrelated changes:
randto 0.6ethcore-blockchain