Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Remove support for hardware wallets #10678

Merged
merged 3 commits into from
May 21, 2019
Merged

Remove support for hardware wallets #10678

merged 3 commits into from
May 21, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented May 20, 2019 •
edited
Loading

Fixes #10677

@dvdplm dvdplm marked this pull request as ready for review May 20, 2019 10:50
@dvdplm dvdplm requested a review from niklasad1 May 20, 2019 10:51
@dvdplm dvdplm self-assigned this May 20, 2019
@dvdplm dvdplm added the A0-pleasereview 🤓 Pull request needs code review. label May 20, 2019
@niklasad1 niklasad1 added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label May 20, 2019
niklasad1
niklasad1 approved these changes May 20, 2019
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we need to cleanup the README after this and remove some dependencies that are not needed anymore

@niklasad1 niklasad1 added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 20, 2019
@dvdplm
Copy link
Collaborator Author

dvdplm commented May 20, 2019

cleanup the README after this and remove some dependencies that are not needed anymore

The README looks fine (i.e. no mention of hardware wallets) and I went looking for libusb and hidapi but found no mention of them. Do you know where I should look?

@niklasad1
Copy link
Collaborator

niklasad1 commented May 20, 2019 •
edited
Loading

The README looks fine (i.e. no mention of hardware wallets) and I went looking for libusb and hidapi but found no mention of them. Do you know where I should look?

My bad, it is only libudev-dev that is not needed anymore and I think the Docker files can be cleaned up (such as the Android libusb hack) but probably better to keep those out of this PR and create issues?

@dvdplm
Copy link
Collaborator Author

dvdplm commented May 20, 2019

but probably better to keep those out of this PR and create issues?

I went ahead and removed them to the best of my knowledge, but if you think it's a bad idea I can revert the commit.

@niklasad1
Copy link
Collaborator

I went ahead and removed them to the best of my knowledge, but if you think it's a bad idea I can revert the commit.

Cool, it looks good

@dvdplm dvdplm merged commit 10c121a into master May 21, 2019
dvdplm added a commit that referenced this pull request May 21, 2019
@dvdplm
Merge branch 'master' into dp/chore/switch-to-new-parity-crypto
02eff51 
* master:
  Remove support for hardware wallets (#10678)
  [CI] allow cargo audit to fail (#10676)
@niklasad1 niklasad1 deleted the dp/chore/remove-hardware-wallet branch May 21, 2019 09:28
ordian added a commit that referenced this pull request May 22, 2019
@ordian
Merge branch 'master' into ao-upgrade-ethereum-types
847c5f1 
* master:
  Remove support for hardware wallets (#10678)
@niklasad1 niklasad1 mentioned this pull request May 25, 2019
Closed
@vkomenda vkomenda mentioned this pull request Oct 17, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@ordian ordian ordian approved these changes

Assignees

@dvdplm dvdplm

Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hardware-wallet] Remove Ledger/Trezor support
3 participants
@dvdplm @niklasad1 @ordian