Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Refactor Clique stepping #10691

Merged
merged 7 commits into from
Jun 10, 2019
Merged

Refactor Clique stepping #10691

merged 7 commits into from
Jun 10, 2019

Commits on May 23, 2019

  1. Use Drop to shutdown stepper thread 

    Make period == 0 an error and remove the Option from step_service
    @dvdplm
    dvdplm committed May 23, 2019
    Configuration menu
    Copy the full SHA
    fe55764 View commit details
    Browse the repository at this point in the history

  2. Remove StepService 

    Remove StepService and spawn the stepping thread in `Clique::new()`. Don't store the thread handle and instead trust the `AtomicBool` to signal shutdown time.
Don't check for `period > 0`: we assume a valid chainspec file.
    @dvdplm
    dvdplm committed May 23, 2019
    Configuration menu
    Copy the full SHA
    709e8fe View commit details
    Browse the repository at this point in the history

  3. Don't shutdown the stepper thread at all, just let it run until exit 

    Also: fix a few warnings and tests
    @dvdplm
    dvdplm committed May 23, 2019
    Configuration menu
    Copy the full SHA
    56eb2ac View commit details
    Browse the repository at this point in the history

  4. Put kvdb_memorydb back

    @dvdplm
    dvdplm committed May 23, 2019
    Configuration menu
    Copy the full SHA
    f12d348 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2019

  1. Warn&exit when engine is dropped 

    Don't sleep too long!
    @dvdplm
    dvdplm committed May 24, 2019
    Configuration menu
    Copy the full SHA
    a403948 View commit details
    Browse the repository at this point in the history

  2. Don't delay stepping thread

    @dvdplm
    dvdplm committed May 24, 2019
    Configuration menu
    Copy the full SHA
    685b334 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Better formatting

    @dvdplm
    dvdplm committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    3bc64bc View commit details
    Browse the repository at this point in the history