Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

updated price-info to edition 2018 #10801

Merged
merged 1 commit into from
Jun 27, 2019
Merged

updated price-info to edition 2018 #10801

merged 1 commit into from
Jun 27, 2019

Conversation

debris
Copy link
Collaborator

@debris debris commented Jun 27, 2019 •
edited by niklasad1
Loading

also removed redundant Error type and unused dev-dependency parking_lot

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Jun 27, 2019
@debris debris requested a review from dvdplm June 27, 2019 05:51
@niklasad1 niklasad1 added the A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. label Jun 27, 2019
@dvdplm
Copy link
Collaborator

dvdplm commented Jun 27, 2019

I've seen WARN price_info Failed to auto-update latest ETH price: Fetch(Timeout) at client startup quite often lately and I think it's spurious as the network is fine otherwise. While you're at it, can you perhaps see if we can increase the timeout a little bit? Or retry?

@debris
Copy link
Collaborator Author

debris commented Jun 27, 2019

I've seen WARN price_info Failed to auto-update latest ETH price: Fetch(Timeout) at client startup quite often lately and I think it's spurious as the network is fine otherwise. While you're at it, can you perhaps see if we can increase the timeout a little bit? Or retry?

I'll prepare it in a separate PR :)

@debris debris merged commit 16e0ad1 into master Jun 27, 2019
@debris debris deleted the price-info-edition branch June 27, 2019 11:38
@ordian ordian added this to the 2.6 milestone Jun 27, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Jun 27, 2019
dvdplm added a commit that referenced this pull request Jun 28, 2019
@dvdplm
Merge branch 'master' into dp/chore/debug-synching-UnlinkedAncientBlo…
25233d1 
…ckChain

* master:
  revert changes to .gitlab-ci.yml (#10807)
  Add filtering capability to `parity_pendingTransactions` (issue 8269) (#10506)
  removed EthEngine alias (#10805)
  wait a bit longer in should_check_status_of_request_when_its_resolved (#10808)
  Do not drop the peer with None difficulty (#10772)
  ethcore-bloom-journal updated to 2018 (#10804)
  ethcore-light uses bincode 1.1 (#10798)
  Fix a few typos and unused warnings. (#10803)
  updated project to ansi_term 0.11 (#10799)
  added new ropsten-bootnode and removed old one (#10794)
  updated price-info to edition 2018 (#10801)
  ethcore-network-devp2p uses igd 0.9 (#10797)
  updated parity-local-store to edition 2018 and removed redundant Error type (#10800)
dvdplm added a commit that referenced this pull request Jul 1, 2019
@dvdplm
Merge branch 'master' into dp/fix/prevent-building-block-on-top-of-sa…
aa99629 
…me-parent

* master: (24 commits)
  cargo update -p smallvec (#10822)
  replace memzero with zeroize crate (#10816)
  Don't repeat the logic from Default impl (#10813)
  removed additional_params method (#10818)
  Add Constantinople eips to the dev (instant_seal) config (#10809)
  removed redundant fmt::Display implementations (#10806)
  revert changes to .gitlab-ci.yml (#10807)
  Add filtering capability to `parity_pendingTransactions` (issue 8269) (#10506)
  removed EthEngine alias (#10805)
  wait a bit longer in should_check_status_of_request_when_its_resolved (#10808)
  Do not drop the peer with None difficulty (#10772)
  ethcore-bloom-journal updated to 2018 (#10804)
  ethcore-light uses bincode 1.1 (#10798)
  Fix a few typos and unused warnings. (#10803)
  updated project to ansi_term 0.11 (#10799)
  added new ropsten-bootnode and removed old one (#10794)
  updated price-info to edition 2018 (#10801)
  ethcore-network-devp2p uses igd 0.9 (#10797)
  updated parity-local-store to edition 2018 and removed redundant Error type (#10800)
  Cleanup unused vm dependencies (#10787)
  ...
dvdplm added a commit that referenced this pull request Jul 3, 2019
@dvdplm
Merge branch 'master' into dp/insipx/insi_mutex-account-bloom
a7b3f47 
* master: (22 commits)
  ethcore does not use byteorder (#10829)
  Better logging when backfilling ancient blocks fail (#10796)
  depends: Update wordlist to v1.3 (#10823)
  cargo update -p smallvec (#10822)
  replace memzero with zeroize crate (#10816)
  Don't repeat the logic from Default impl (#10813)
  removed additional_params method (#10818)
  Add Constantinople eips to the dev (instant_seal) config (#10809)
  removed redundant fmt::Display implementations (#10806)
  revert changes to .gitlab-ci.yml (#10807)
  Add filtering capability to `parity_pendingTransactions` (issue 8269) (#10506)
  removed EthEngine alias (#10805)
  wait a bit longer in should_check_status_of_request_when_its_resolved (#10808)
  Do not drop the peer with None difficulty (#10772)
  ethcore-bloom-journal updated to 2018 (#10804)
  ethcore-light uses bincode 1.1 (#10798)
  Fix a few typos and unused warnings. (#10803)
  updated project to ansi_term 0.11 (#10799)
  added new ropsten-bootnode and removed old one (#10794)
  updated price-info to edition 2018 (#10801)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
4 participants
@debris @dvdplm @niklasad1 @ordian