This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix compile warnings #10993
Merged
fix compile warnings #10993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
added
A0-pleasereview 🤓
ordian
added
A8-looksgood 🦄
ordian
approved these changes
Aug 27, 2019
dvdplm
added
A7-looksgoodtestsfail 🤖
ordian
reviewed
Aug 27, 2019
niklasad1
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Aug 27, 2019
* master: fix compile warnings (#10993)
dvdplm
added a commit
that referenced
this pull request
Aug 28, 2019
dvdplm
added a commit
that referenced
this pull request
Aug 28, 2019
…/eip-1884-reprice-trie-size-dependent-ops * dp/feature/eip-1344-add-ChainID-opcode: more merge fallout Update ethcore/vm/src/schedule.rs Fix a few warnings merge conflict error Make ClientIoMessage generic over the Client (#10981) bump spin to 0.5.2 (#10996) fix compile warnings (#10993) Fix compilation on recent nightlies (#10991) [ipfs] Convert to edition 2018 (#10979)
ordian
added a commit
to ordian/parity
that referenced
this pull request
Aug 29, 2019
* master: EIP 1884 Re-pricing of trie-size dependent operations (openethereum#10992) xDai chain support and nodes list update (openethereum#10989) [trace] check mem diff within range (openethereum#11002) EIP-1344 Add CHAINID op-code (openethereum#10983) Make ClientIoMessage generic over the Client (openethereum#10981) bump spin to 0.5.2 (openethereum#10996) fix compile warnings (openethereum#10993)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates a bunch of compiler warnings most of them were
bare-trait-objecti.e., replaced bydyn trait.Tried
cargo fixfirst but then I fixed the rest of them manually