-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ethcore/res: bump canon fork hash for mordor and kotti testnets #11584
Conversation
@@ -24,8 +24,8 @@ | |||
"minGasLimit": "0x1388", | |||
"networkID": "0x7", | |||
"chainID": "0x3f", | |||
"forkBlock": "0xcd16a", | |||
"forkCanonHash": "0x7b4145006cddae9e88c13b47d6aeee2ab4c37d561b929cf688f6f35d58d1966b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that block didn't make it into the main chain
> eth.getBlock(0xcd16a)
{
difficulty: 921182,
extraData: "0x",
gasLimit: 4712388,
gasUsed: 0,
hash: "0x17f6cc524412278600cd196fdd387bec899146ac6bf360eac419e3b75192888c",
logsBloom: "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
miner: "0xd4616c89247a4bb2fbebaef15fd10fa38eca15dc",
mixHash: "0x13404b3486d29847c27caab5bf1da828d9b7854eed2e4f554f6f784dcdc4678c",
nonce: "0x70631a4f60bea2b2",
number: 840042,
parentHash: "0x3ba097fdcd4c2ffa0ffac294bf56bf7473f172ef55276f62c679e4052a7cf13d",
receiptsRoot: "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
sha3Uncles: "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347",
size: 514,
stateRoot: "0x4b85846591018b090e11497a2f4f77876d25c0983a5c4776fcbe80032ce5373d",
timestamp: 1581212828,
totalDifficulty: 1025372183168,
transactions: [],
transactionsRoot: "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
uncles: []
}
Can you elaborate on what happened? Was there a mistake in the spec file? Or…? |
The Aztlan ECIP 1061 was proposed to be appended with ECIP 1078 and this was implemented on the testnets for testing purposes. Both ECIP 1061 and 1078 were meant to be a bundle, therefore they had the same block number on the mainnet. However, the timing of the hardforks for testing purposes was less conservative, and therefore ECIP 1061 already activated on both testnets before 1078 could be scheduled. That time between 1061 and 1078 activation on Mordor and Kotti lead to a series of side-effects including consensus split between Besu and Geth/Parity. See ethereum/EIPs#2526 ethereum/EIPs#2514 ethereum/go-ethereum#20646 and #11474 Eventually, it was decided to pull 1061 and 1078 altogether and replace it cleanly with a single hardfork (ECIP 1088) that would not have these issues. ETC Labs Core, ChainSafe, and Byzantine Fault advised to go that route. https://medium.com/ethereum-classic-labs/advisory-to-reject-ecip-1061-aztlan-and-ecip-1078-phoenixfix-for-ethereum-classic-28df21a206c The community accepted that path with 1088 and rejected 1061, 1078, and 1086 ethereumclassic/ECIPs#298 ethereumclassic/ECIPs#297 There is a lot of background information on Github ethereumclassic/ECIPs#217 ethereumclassic/ECIPs#226 ethereumclassic/ECIPs#227 ethereumclassic/ECIPs#262 This Gist explains the historical context reaching all the way back to Constantinople issues on Ethereum network https://gist.github.com/meowsbits/ddf54e7cb225e7f89b3ed0b7d92b8a37 So, for the testnets it required some reconfiguration and invalidating the Aztlan chain in favor of a Phoenix chain. I hope that answers your question. |
* master: (25 commits) Update .gitmodules (#11628) ethcore/res: activate ecip-1088 phoenix on classic (#11598) Upgrade parity-common deps to latest (#11620) Fix Goerli syncing (#11604) deps: switch to upstream ctrlc (#11617) Deduplicating crate dependencies (part 3 of n) (#11614) Deduplicating crate dependencies (part 2 of n, `slab`) (#11613) Actually save ENR on creation and modification (#11602) Activate POSDAO on xDai chain and update bootnodes (#11610) Activate on-chain randomness in POA Core (#11609) Deduplicating crate dependencies (part 1 of n) (#11606) Update enodes for POA Sokol (#11611) Remove .git folder from dogerignore file so vergen library can get build date and commit hash in the binary generatio vergen library can get build date and commit hash in the binary generation (#11608) Reduced gas cost for static calls made to precompiles EIP2046/1352 (#11583) [easy] `ethcore-bloom-journal` was renamed to `accounts-bloom` (#11605) Use serde_json to export hardcoded sync (#11601) Node Discovery v4 ENR Extension (EIP-868) (#11540) Fix compile warnings (#11595) Update version to 3.0.0-alpha.1 (#11592) ethcore/res: bump canon fork hash for mordor and kotti testnets (#11584) ...
both testnets were recently recovered. the fork hashes help clients to identify healthy peers.
bonus: updated kotti bootnodes. ref hyperledger/besu#590 etclabscore/core-geth#84