-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Implementation of EIP 2537 #11707
Implementation of EIP 2537 #11707
Conversation
cc #11697 |
I'll review the https://github.com/matter-labs/eip1962/tree/1c79dba99c970c99066e249627c29b38dc949677 that is the used revision at this moment. |
Updated with a constant and specific revision |
@sorpaas, if you have time, could you review it, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo some convention nits by @sorpaas and me
I'll fix those tomorrow |
@vorot93 Ubuntu tests looks to go fine, but were cancelled due to MacOS tests. For MacOS tests I can not see logs and find an error, can you help me with it? |
All tests pass on my MacOS laptop by the way |
Restarted the tests |
ethcore/res/ethereum/foundation.json
Outdated
"0x7fffffffffffff": { | ||
"price": { "bls12_const_operations": { "price": 600 }} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"0x7fffffffffffff": { | |
"price": { "bls12_const_operations": { "price": 600 }} | |
} | |
"bls12_const_operations": { "price": 600 } |
Either you set
activate_at
:block_number
, andpricing
>bls12_const_operations
if there's a single pricing, orpricing
>block_number
>price
>bls12_const_operations
if pricing is expected to change
but not both!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part I didn't change, only fixed names there and activation to be in a distant future as was suggested above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed this part, but still needs to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed now
"0": { | ||
"price": { "bls12_const_operations": { "price": 600 }} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"0": { | |
"price": { "bls12_const_operations": { "price": 600 }} | |
} | |
"bls12_const_operations": { "price": 600 } |
also the same in this spec
* master: Update parity-crypto dependency (#11791) ethcore/private-tcx: fix deadlock caused by conflicting lock order (#11764) Feature/publish draft release ci (#11786) Trigger custom docker build when adding ci-build-docker to the commit (#11782) Fix alpine docker image entry point (#11749) Use BigUint::modpow for ModExp precompile (#11772) Add YOLO-1 testnet (#11757) Upgrade num to 0.2, use enum-primitive-derive (#11636) Update Simple Subroutines to the latest spec (#11731) update secret-store reference (#11761) Implementation of EIP 2537 (#11707) Add missing forks to fork ID (#11747) Use nightly tag for master branch (#11732)
…ereum/openethereum into dp/chore/upgrade-to-rocksdb-0.14 * 'dp/chore/upgrade-to-rocksdb-0.14' of github.com:openethereum/openethereum: Update parity-crypto dependency (#11791) ethcore/private-tcx: fix deadlock caused by conflicting lock order (#11764) Feature/publish draft release ci (#11786) Trigger custom docker build when adding ci-build-docker to the commit (#11782) Fix alpine docker image entry point (#11749) Use BigUint::modpow for ModExp precompile (#11772) Add YOLO-1 testnet (#11757) Upgrade num to 0.2, use enum-primitive-derive (#11636) Update Simple Subroutines to the latest spec (#11731) update secret-store reference (#11761) Implementation of EIP 2537 (#11707) Add missing forks to fork ID (#11747) Use nightly tag for master branch (#11732)
This PR implements EIP 2537 using the full reference implementation from here (specialized BLS12-381 engine).
Both json specs and native builtins are implemented (pricers and executors).
Closes #11677