This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Disable WAL #1765
Merged
Disable WAL #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A8-looksgood 🦄
|
probably worth having WAL optional but defaulting to off. |
gavofyork
added
A6-mustntgrumble 💦
arkpar
added
A3-inprogress ⏳
|
(i'm working on that now.) |
gavofyork
added
A0-pleasereview 🤓
| @@ -314,6 +314,7 @@ pub struct Args { | |||
| pub flag_cache_size_queue: u32, | |||
| pub flag_cache_size: Option<u32>, | |||
| pub flag_cache: Option<u32>, | |||
| pub flag_fast_and_loose: bool, | |||
arkpar
added
A6-mustntgrumble 💦
arkpar
added
A8-looksgood 🦄
5chdn
added a commit
that referenced
this pull request
Jul 2, 2018
dvdplm
pushed a commit
that referenced
this pull request
Jul 10, 2018
* parity: highlight --fast-and-loose is not recommended. * parity: remove fast-and-loose option, ref #1765 * db: remove db wal from options, it's always enabled * db: remove wal from rocksdb helpers * cli: fix wallet import test * ethcore: fix client config tests * parity: proper deprecated handling for fast-and-loose * ethcore-client: fix config * parity: mark fast-and-loose removed * parity: fix test_find_deprecated * parity: fix type for fast-and-loose flag * lock file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/facebook/rocksdb/wiki/Known-Issues
"Atomicity is not guaranteed after DB recovery for more than one multiple column families and WAL is disabled."
This makes import 5% slower but guarantees DB recovery.
should also fix #1760