This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
EIP-140 REVERT opcode #5477
Merged
EIP-140 REVERT opcode #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
rphmeier
reviewed
Apr 19, 2017
ethcore/src/evm/evm.rs
Outdated
| /// Finalization result. Gas Left: either it is a known value, or it needs to be computed by processing | ||
| /// a return instruction. | ||
| #[derive(Debug)] | ||
| pub struct FinalizationResut { |
rphmeier
reviewed
Apr 19, 2017
ethcore/src/evm/interpreter/mod.rs
Outdated
| // gas left, init_orf, init_size | ||
| StopExecutionNeedsReturn(Gas, U256, U256), | ||
| // gas left, init_off, init_size | ||
| StopExecutionNeedsReturn { |
There was a problem hiding this comment.
comment here could indicate that apply means "apply changes"
This was referenced Apr 21, 2017
Closed
NikVolf
reviewed
May 23, 2017
ethcore/src/evm/evm.rs
Outdated
| @@ -114,14 +131,18 @@ pub enum GasLeft<'a> { | |||
| /// `Reult<GasLeft<'a>>`. | |||
| pub trait Finalize { | |||
| /// Consume the externalities, call return if necessary, and produce a final amount of gas left. | |||
There was a problem hiding this comment.
Finalization result is more than just gas now, doc comment should reflect this?
NikVolf
added
A6-mustntgrumble 💦
gavofyork
approved these changes
May 23, 2017
arkpar
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum/EIPs#206