Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

EIP-140 REVERT opcode #5477

Merged
merged 1 commit into from
May 23, 2017
Merged

EIP-140 REVERT opcode #5477

merged 1 commit into from
May 23, 2017

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Apr 19, 2017

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Apr 19, 2017
@arkpar arkpar changed the title EIP-140 EIP-140 REVERT opcode Apr 19, 2017
/// Finalization result. Gas Left: either it is a known value, or it needs to be computed by processing
/// a return instruction.
#[derive(Debug)]
pub struct FinalizationResut {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result

// gas left, init_orf, init_size
StopExecutionNeedsReturn(Gas, U256, U256),
// gas left, init_off, init_size
StopExecutionNeedsReturn {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment here could indicate that apply means "apply changes"

@@ -114,14 +131,18 @@ pub enum GasLeft<'a> {
/// `Reult<GasLeft<'a>>`.
pub trait Finalize {
/// Consume the externalities, call return if necessary, and produce a final amount of gas left.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finalization result is more than just gas now, doc comment should reflect this?

@NikVolf NikVolf added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 23, 2017
@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels May 23, 2017
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 23, 2017
@NikVolf NikVolf merged commit dd004ab into master May 23, 2017
@NikVolf NikVolf deleted the eip140 branch May 23, 2017 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants