This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add support for ConsenSys multisig wallet #6153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Spend a lot of time on the new calculations as well, just double-checking the logic - was not 100% sure why it was re-done here without splitting it out, makes the PR bigger and the logic much more fragile and difficult to follow. Would really need your help to port this to UI-2 as well, where everything now lives in separate repos ( |
jacogr
added
A8-looksgood 🦄
ngotchac
added a commit
that referenced
this pull request
Aug 18, 2017
* First draft of ConsenSys wallet * Fix transfer store // WIP Consensys Wallet * Rename walletABI JSON file * Fix linting * Fix wrong daylimit in wallet modal * Confirm/Revoke ConsensysWallet txs * Linting * Change of settings for the Multisig Wallet
Merged
arkpar
pushed a commit
that referenced
this pull request
Aug 18, 2017
* Time should not contribue to overall status. (#6276) * Add warning to web browser and fix links. (#6232) * Extension fixes (#6284) * Fix token symbols in extension. * Allow connections from firefox extension. * Add support for ConsenSys multisig wallet (#6153) * First draft of ConsenSys wallet * Fix transfer store // WIP Consensys Wallet * Rename walletABI JSON file * Fix linting * Fix wrong daylimit in wallet modal * Confirm/Revoke ConsensysWallet txs * Linting * Change of settings for the Multisig Wallet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for this multisig wallet. It should also be easier to add support for other Wallets now.
It also fixes a bug in the Transfer modal when sending a token from a Wallet that has no ETH.
NB : there might be some gas estimation issues when for example confirming an owner addition. As this version of the Multisig Wallet doesn't throw when the executed call fails, the gas estimation is a bit undervalued.