This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
separate migration from util and make its dependencies into libs #6573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hawstein
force-pushed
the
separate-migrations-from-util
branch
2 times, most recently
from
90a1b34
to
0429cec
Compare
gavofyork
added
A0-pleasereview 🤓
|
This branch has conflicts. |
5chdn
added
A4-gotissues 💥
Hawstein
force-pushed
the
separate-migrations-from-util
branch
from
0429cec
to
f196c50
Compare
|
@5chdn Conflicts resolved. |
5chdn
added
A0-pleasereview 🤓
|
doesn't build... |
|
CI issues
@paritytech/ci ? |
5chdn
added
the
A4-awaitingci 🤖
debris
reviewed
Oct 9, 2017
| rlp = { path = "../rlp" } | ||
| ethcore-bigint = { path = "../bigint" } | ||
| snappy = { path = "../snappy" } | ||
| error-chain = "0.11.0-rc.2" |
There was a problem hiding this comment.
it would be good to use a single version of error-chain. this pr uses 2 different (0.11 and 0.11-rc2)
There was a problem hiding this comment.
Only version 0.11.0-rc.2 is used. I believe 0.11.0 is auto generated in Cargo.lock which will just drop the suffix rc.2.
Hawstein
force-pushed
the
separate-migrations-from-util
branch
from
f196c50
to
4db86cf
Compare
* snappy * kvdb * error * common
Hawstein
force-pushed
the
separate-migrations-from-util
branch
from
4db86cf
to
445ad2a
Compare
|
@gavofyork @5chdn @debris Now all checks pass. |
5chdn
removed
the
A4-awaitingci 🤖
|
I have a couple of grumbles, but I will fix them by myself and reopen the pr |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6418
separate migration from util and make its dependencies into libs: