Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

SecretStore: ShareRemove of 'isolated' nodes #6630

Merged
merged 7 commits into from
Oct 5, 2017

Conversation

svyatonik
Copy link
Collaborator

It is a fix of TODO4 from #6605

The case is:

  1. node is permanently removed because of failure (for example)
  2. we decide to remove/add share to the key, this node holds share for
    In current implementation every node that have a share of given key, must participate in any admin session with this key. Obviously, it is impossible in this case, because node(s) is already 'isolated' from cluster.

So the idea is to give ability to run admin sessions even if some owners of shares are already isolated:

  1. ShareRemove is changed, so that it can be runned without communicating to isolated nodes - i.e. you can 'forget' isolated nodes.
  2. it is still impossible to run ShareAdd && ShareMove with 'isolated' participants
  3. ServesSetChange session is changed so that for every key 'isolated' nodes are removed in prior to adding/moving key shares

Since in (1) session is started explicitely by administrator && in (3) only isolated nodes which are not in new_nodes_set are removed, we may assume that isolated node is not going to return.
But this case (re-addition of isolated node to the cluster) should be taken into account when working on TODO#3 from #6605.

@svyatonik svyatonik added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 4, 2017
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 5, 2017
@NikVolf
Copy link
Contributor

NikVolf commented Oct 5, 2017

need rebase @svyatonik

@svyatonik
Copy link
Collaborator Author

Thanks!

@NikVolf NikVolf merged commit 6431459 into master Oct 5, 2017
@NikVolf NikVolf deleted the secretstore_remove_share_from_isolated_node branch October 5, 2017 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants