Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

More geth compatibility. #666

Merged
merged 4 commits into from
Mar 11, 2016
Merged

More geth compatibility. #666

merged 4 commits into from
Mar 11, 2016

Conversation

gavofyork
Copy link
Contributor

No description provided.

@NikVolf NikVolf added the A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. label Mar 10, 2016
(listen_address, public_address)
}

fn net_settings(&self, spec: &Spec) -> NetworkConfiguration {
let mut ret = NetworkConfiguration::new();
ret.nat_enabled = !self.args.flag_no_upnp;
ret.nat_enabled = self.args.flag_nat == "any" || self.args.flag_nat == "upnp";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and this? perhaps we should make an option from flag_nat and flag_port and pass directly into the network layer?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If "any" means "auto" then setting flag_nat is ok. It will fallback to detecting interface address if upnp failed

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Mar 10, 2016
@arkpar arkpar added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Mar 11, 2016
@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Mar 11, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 11, 2016
NikVolf added a commit that referenced this pull request Mar 11, 2016
@NikVolf NikVolf merged commit 22d1def into master Mar 11, 2016
@gavofyork gavofyork deleted the moregethcli branch March 15, 2016 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants