This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Check vouch status on appId in addition to contentHash #6719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
commented
Oct 12, 2017
js/src/ui/DappVouchFor/store.js
Outdated
| } | ||
|
|
||
| async attachContract () { | ||
| const address = await Contracts.get().registry.lookupAddress('vouchfor'); |
There was a problem hiding this comment.
Don't lookup contract address per instance and only create a single contract that is used for queries across stores. (next couple of lines after this). Optimisation as discussed in the previous PR.
jacogr
commented
Oct 12, 2017
js/src/ui/DappVouchFor/store.js
Outdated
| return contract; | ||
| } | ||
|
|
||
| async findVouchers (contentHash, id) { |
There was a problem hiding this comment.
Made everything async/await to simplify as per comments from previous PR.
gavofyork
added
A8-looksgood 🦄
jacogr
added a commit
that referenced
this pull request
Oct 12, 2017
* Check vouch status on appId in addition to contentHash * Simplify var expansion
arkpar
pushed a commit
that referenced
this pull request
Oct 12, 2017
arkpar
pushed a commit
that referenced
this pull request
Oct 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically allow lookups on both the contentHash and the appId for vouching. (De-dupe results). Just using the contentHash leads to the situation where the count gets lost when the app is actually updated.
Screenshot shows dapp with verification from both contentHash and appId.