Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Disable uncles by default #7006

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Disable uncles by default #7006

merged 1 commit into from
Nov 15, 2017

Conversation

keorn
Copy link

@keorn keorn commented Nov 8, 2017

No description provided.

@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Nov 8, 2017
@rphmeier rphmeier changed the title Disable uncles by default Disable uncles by default in Aura Nov 8, 2017
@rphmeier rphmeier added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Nov 8, 2017
@keorn keorn changed the title Disable uncles by default in Aura Disable uncles by default Nov 8, 2017
@rstormsf
Copy link

rstormsf commented Nov 8, 2017

👍 merge!

@5chdn
Copy link
Contributor

5chdn commented Nov 10, 2017

This affects Kovan and all PoA, does it?

@5chdn 5chdn added this to the 1.9 milestone Nov 10, 2017
@keorn
Copy link
Author

keorn commented Nov 10, 2017

Kovan will stay the same, it just works for new chains. If one wants to keep running a chain with uncles they have to add maximumUncleCount: 2 to the chain spec.

@debris
Copy link
Collaborator

debris commented Nov 14, 2017

How exactly is this value used? I can't see

@rstormsf
Copy link

#7065

@keorn
Copy link
Author

keorn commented Nov 15, 2017

@debris It determines the maximum number of uncles included in a block. Uncles are a fairly Ethash specific thing, so they should not be enabled by default.

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 15, 2017
@debris debris merged commit 605cd5c into master Nov 15, 2017
@debris debris deleted the no-uncles branch November 15, 2017 22:51
@5chdn 5chdn mentioned this pull request Nov 20, 2017
25 tasks
tomusdrw pushed a commit that referenced this pull request Dec 5, 2017
tomusdrw pushed a commit that referenced this pull request Dec 5, 2017
tomusdrw pushed a commit that referenced this pull request Dec 5, 2017
@5chdn 5chdn added the B0-patch label Dec 6, 2017
arkpar pushed a commit that referenced this pull request Dec 8, 2017
* Merge pull request #7075 from miyao-gmo/feature/estimate_gas_limit

escape inifinite loop in estimte_gas

* Merge pull request #7006 from paritytech/no-uncles

Disable uncles by default

* Maximum uncle count transition (#7196)

* Enable delayed maximum_uncle_count activation.

* Fix tests.

* Defer kovan HF.

* Bump version.

* Kovan HF.

* Update Kovan HF block.

* Fix compilation issues.

* Fix aura test.

* Add missing byzantium builtins.

* Fix tests.

* Bump version for installers.

* Increase allowed time drift to 10s. (#7238)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants