This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Cleaner binary shutdown system #8284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-pleasereview 🤓
debris
reviewed
Apr 4, 2018
| /// Set a closure to call when the client wants to be restarted. | ||
| /// | ||
| /// The parameter passed to the callback is the name of the new chain spec to use after | ||
| /// the restart. |
There was a problem hiding this comment.
finally a proper description of a function! 👍
| fn execute_impl<Cr, Rr>(cmd: RunCmd, logger: Arc<RotatingLogger>, on_client_rq: Cr, | ||
| on_updater_rq: Rr) -> Result<RunningClient, String> | ||
| where Cr: Fn(String) + 'static + Send, | ||
| Rr: Fn() + 'static + Send |
There was a problem hiding this comment.
do you know why doesn't updater care about the spec? isn't it a bug?
There was a problem hiding this comment.
I don't know how the updater works unfortunately
There was a problem hiding this comment.
you're right, it's not related to this pr. I'll ask andre
There was a problem hiding this comment.
@andresilva told me that everything's good :)
I think it's fine because the updater gets all its info from the operations contract, so it doesn't need the chainspec
so only the client needs to be updated with the new spec, and the updater will use the updated client to interact with the operations contract
debris
approved these changes
Apr 4, 2018
debris
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4842
Refactors a bit of the code of
parity/run.rsin order to have a better separation between the code that runs the client and the code that handles the ctrl+c and thecan_restartoption.