This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Parity as a library #8337
Closed
Parity as a library #8337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-pleasereview 🤓
|
Going to restart from scratch, I'm in a clusterfuck of merge conflicts. |
5chdn
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #4842
This extracts most of the content of the
paritycrate into a new crate namedparity-lib.The
paritycrate mostly contains themainfunction, plus everything that is related to restarting the binary and applying updates.The API of
parity-libconsists in a singlestartfunction that accepts a list of CLI arguments as strings.While accepting arguments as strings is not a great thing to do, it is the most straight-forward solution for now and can always be improved in the future.
Also for now
startjust blocks until we Ctrl+C or an update is ready or an RPC request to change the chain happens. This is obviously not great either and will be changed in the future. However I don't want to introduce too many changes at once because of conflicts with other PRs (eg. #8262) and the hell of solving conflicts.I recommend reviewing commits one by one for an easier review. The first commit simply moves files, and the other ones apply some changes.