Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ethstore: retry deduplication of wallet file names until success #8910

Merged
merged 1 commit into from
Jun 20, 2018
Merged

ethstore: retry deduplication of wallet file names until success #8910

merged 1 commit into from
Jun 20, 2018

Conversation

andresilva
Copy link
Contributor

No description provided.

@andresilva andresilva added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jun 15, 2018
sorpaas
sorpaas approved these changes Jun 18, 2018
View reviewed changes
Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@5chdn 5chdn added this to the 1.12 milestone Jun 18, 2018
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 20, 2018
@sorpaas sorpaas merged commit cf5ae81 into master Jun 20, 2018
@debris debris deleted the andre/fix-wallet-import-collision branch June 20, 2018 10:17
dvdplm added a commit that referenced this pull request Jun 20, 2018
@dvdplm
Merge branch 'master' into refactor/hashdb-generic
c366b2a 
* master:
  ethstore: retry deduplication of wallet file names until success (#8910)
  Update ropsten.json (#8926)
  Include node identity in the P2P advertised client version. (#8830)
  Allow disabling local-by-default for transactions with new config entry (#8882)
  Allow Poll Lifetime to be configured via CLI (#8885)
ordian added a commit to ordian/parity that referenced this pull request Jun 20, 2018
@ordian
merge with master
5712c35 
* 'master' of https://github.com/paritytech/parity:
  new blooms database (openethereum#8712)
  ethstore: retry deduplication of wallet file names until success (openethereum#8910)
  Update ropsten.json (openethereum#8926)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@sorpaas sorpaas sorpaas approved these changes

@ascjones ascjones ascjones approved these changes

@debris debris Awaiting requested review from debris

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.0 Ethereum
Development

Successfully merging this pull request may close these issues.
5 participants
@andresilva @ascjones @sorpaas @niklasad1 @5chdn