Remove all dapp permissions related settings #9120

sorpaas · 2018-07-13T16:10:58Z

Should only be merged after #9107. I submit this as a separate PR because this may need more polishing, or I may have removed too many stuff.

Completely remove dapp permission settings from AccountProvider and RPC:

In RPC, all available accounts are returned, regardless of the origin. (Previously we return accounts based on dapps policy).
It's not possible to set "default account" (as for dapps) any more. This is always the first account in the available account list.

5chdn · 2018-07-16T19:11:33Z

there is conflict now in rpc.

tomusdrw

Couple of grumbles

tomusdrw · 2018-07-23T13:35:31Z

rpc/src/v1/extractors.rs

-				(None, Some(service), _) => Origin::Rpc(service.into()),
-				(None, _, _) => Origin::Rpc("unknown".into()),
+			origin: match user_agent {
+				Some(service) => Origin::Rpc(service.into()),


I think it might be good to actually use the Origin as well (if available)

tomusdrw · 2018-07-23T13:35:43Z

rpc/src/v1/extractors.rs

@@ -36,13 +36,11 @@ pub struct RpcExtractor;
 impl HttpMetaExtractor for RpcExtractor {
 	type Metadata = Metadata;

-	fn read_metadata(&self, origin: Option<String>, user_agent: Option<String>, dapps_origin: Option<String>) -> Metadata {
+	fn read_metadata(&self, _origin: Option<String>, user_agent: Option<String>, _dapps_origin: Option<String>) -> Metadata {


Should we get rid of _dapps_origin in the trait?

tomusdrw · 2018-07-23T13:36:19Z

rpc/src/v1/impls/eth.rs

-	fn author(&self, meta: Metadata) -> Result<RpcH160> {
-		let dapp = meta.dapp_id();
-
+	fn author(&self, _meta: Metadata) -> Result<RpcH160> {


Don't need the Meta on the trait level I suppose.

tomusdrw · 2018-07-23T13:36:28Z

rpc/src/v1/impls/eth.rs

-		let dapp = meta.dapp_id();
-
-		let accounts = self.dapp_accounts(dapp.into())?;
+	fn accounts(&self, _meta: Metadata) -> Result<Vec<RpcH160>> {


Same as above

tomusdrw · 2018-07-23T13:36:50Z

rpc/src/v1/impls/light/parity.rs

-	fn accounts_info(&self, dapp: Trailing<DappId>) -> Result<BTreeMap<H160, AccountInfo>> {
-		let dapp = dapp.unwrap_or_default();
-
+	fn accounts_info(&self) -> Result<BTreeMap<H160, AccountInfo>> {


Should we accept (and ignore) the trailing param for backward compatibility?

The issue is that we removed several methods, so it's already breaking backward compatibility no matter what. Would it still be useful to keep backward compatibility just for this function?

tomusdrw · 2018-07-23T13:37:09Z

rpc/src/v1/impls/parity.rs

-		let dapp_accounts = self.accounts
-			.note_dapp_used(dapp.clone().into())
-			.and_then(|_| self.accounts.dapp_addresses(dapp.into()))
+	fn accounts_info(&self) -> Result<BTreeMap<H160, AccountInfo>> {


same as with accounts()

tomusdrw · 2018-07-23T13:37:19Z

rpc/src/v1/impls/parity.rs

-
-		Ok(self.accounts
-			.dapp_default_address(dapp_id.into())
+	fn default_account(&self, _meta: Self::Metadata) -> Result<H160> {


Remove meta on the trait level

tomusdrw · 2018-07-23T13:39:08Z

rpc/src/v1/metadata.rs

-			_ => DappId::default(),
-		}
-	}
-
 	/// Returns true if the request originates from a Dapp.
 	pub fn is_dapp(&self) -> bool {


Maybe just remove completelty?

tomusdrw · 2018-07-23T13:39:38Z

rpc/src/v1/traits/parity_accounts.rs

-		/// Setting `None` will resets visible account to what's visible for new dapps
-		/// (does not affect default account though)
-		#[rpc(name = "parity_setDappAddresses")]
-		fn set_dapp_addresses(&self, DappId, Option<Vec<H160>>) -> Result<bool>;


I wonder if we should mark the methods as deprecated first and only remove them in the next version?

cc @5chdn. But I think we have 2.0 so it's okay to break backward compatibility from there? ;)

Let's remove them for 2.0.1 and highlight that in release notes.

tomusdrw · 2018-07-23T13:41:04Z

rpc/src/v1/types/provenance.rs

-			Origin::Ws { ref session, ref dapp } => write!(f, "{} via WebSocket (session: {})", dapp, session),
-			Origin::Signer { ref session, ref dapp } => write!(f, "{} via UI (session: {})", dapp, session),
+			Origin::Ws { ref session } => write!(f, "WebSocket (session: {})", session),
+			Origin::Signer { ref session } => write!(f, "Signer (session: {})", session),


Signer might not be the most descriptive, maybe Secure Session

…-remove-dapp-permissions

debris · 2018-08-07T09:50:28Z

@tomusdrw @andresilva please review

tomusdrw

one more tiny little grumble regarding origin

tomusdrw · 2018-08-07T10:13:17Z

rpc/src/v1/extractors.rs

 		Metadata {
-			origin: match user_agent {
+			origin: match user_agent.or(origin) {


IMHO should be other way around, Origin provides more info than UserAgent. Maybe best just do:

let service = format!("{} / {}", origin.unwrap_or("unknown origin"), user_agent.unwrap_or("unknown agent"));

?

…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: ethcore: add transition flag for transaction permission contract (openethereum#9275) Remove all dapp permissions related settings (openethereum#9120) Improve return data truncate logic (openethereum#9254) Update wasm-tests hash (openethereum#9295) Implement KIP4: create2 for wasm (openethereum#9277) Fix loop start value (openethereum#9285) Avoid using $HOME if not necessary (openethereum#9273) Fix path to parity.h (openethereum#9274)

amaury1093 · 2018-08-17T14:03:46Z

The wiki should also be updated: https://wiki.parity.io/JSONRPC-parity_accounts-module

* Completely remove all dapps struct from rpc * Remove unused pub use * Remove dapp policy/permission func in ethcore * Remove all dapps settings from rpc * Fix rpc tests * Use both origin and user_agent * Address grumbles * Address grumbles * Fix tests

* parity-version: bump beta to 2.0.2 * remove ssl from dockerfiles, closes #8880 (#9195) * snap: remove ssl dependencies from snapcraft definition (#9222) * parity-version: bump beta to 2.0.3 * Remove all dapp permissions related settings (#9120) * Completely remove all dapps struct from rpc * Remove unused pub use * Remove dapp policy/permission func in ethcore * Remove all dapps settings from rpc * Fix rpc tests * Use both origin and user_agent * Address grumbles * Address grumbles * Fix tests * Check if synced when using eth_getWork (#9193) (#9210) * Check if synced when using eth_getWork (#9193) * Don't use fn syncing * Fix identation * Fix typo * Don't check for warping * rpc: avoid calling queue_info twice on eth_getWork * Fix potential as_usize overflow when casting from U256 in miner (#9221) * Allow old blocks from peers with lower difficulty (#9226) Previously we only allow downloading of old blocks if the peer difficulty was greater than our syncing difficulty. This change allows downloading of blocks from peers where the difficulty is greater then the last downloaded old block. * Update Dockerfile (#9242) * Update Dockerfile fix Docker build * fix dockerfile paths: parity -> parity-ethereum (#9248) * Propagate transactions for next 4 blocks. (#9265) Closes #9255 This PR also removes the limit of max 64 transactions per packet, currently we only attempt to prevent the packet size to go over 8MB. This will only be the case for super-large transactions or high-block-gas-limit chains. Patching this is important only for chains that have blocks that can fit more than 4k transactions (over 86M block gas limit) For mainnet, we should actually see a tiny bit faster propagation since instead of computing 4k pending set, we only need `4 * 8M / 21k = 1523` transactions. Running some tests on `dekompile` node right now, to check how it performs in the wild. * Update tobalaba.json (#9313) * Fix load share (#9321) * fix(light_sync): calculate `load_share` properly * refactor(api.rs): extract `light_params` fn, add test * style(api.rs): add trailing commas * ethcore: fix pow difficulty validation (#9328) * ethcore: fix pow difficulty validation * ethcore: validate difficulty is not zero * ethcore: add issue link to regression test * ethcore: fix tests * ethcore: move difficulty_to_boundary to ethash crate * ethcore: reuse difficulty_to_boundary and boundary_to_difficulty * ethcore: fix grumbles in difficulty_to_boundary_aux * Light client `Provide default nonce in transactions when it´s missing` (#9370) * Provide `default_nonce` in tx`s when it´s missing When `nonce` is missing in a `EthTransaction` will cause it to fall in these cases provide `default_nonce` value instead! * Changed http:// to https:// on Yasm link (#9369) Changed http:// to https:// on Yasm link in README.md * Provide `default_nonce` in tx`s when it´s missing When `nonce` is missing in a `EthTransaction` will cause it to fall in these cases provide `default_nonce` value instead! * Address grumbles * ethcore: kovan: delay activation of strict score validation (#9406) * Better support for eth_getLogs in light mode (#9186) * Light client on-demand request for headers range. * Cache headers in HeaderWithAncestors response. Also fulfills request locally if all headers are in cache. * LightFetch::logs fetches missing headers on demand. * LightFetch::logs limit the number of headers requested at a time. * LightFetch::logs refactor header fetching logic. * Enforce limit on header range length in light client logs request. * Fix light request tests after struct change. * Respond to review comments. * Add update docs script to CI (#9219) * Add update docs script to CI Added a script to CI that will use the jsonrpc tool to update rpc documentation then commit and push those to the wiki repo. * fix gitlab ci lint * Only apply jsonrpc docs update on tags * Update gitlab-rpc-docs.sh * Copy correct parity repo to jsonrpc folder Copy correct parity repo to jsonrpc folder before attempting to build docs since the CI runner clones the repo as parity and not parity-ethereum. * Fix JSONRPC docs CI job Update remote config in wiki repo before pushing changes using a github token for authentication. Add message to wiki tag when pushing changes. Use project directory to correctly copy parity code base into the jsonrpc repo for doc generation. * Fix set_remote_wiki function call in CI * Prevent blockchain & miner racing when accessing pending block. (#9310) * Prevent blockchain & miner racing when accessing pending block. * Fix unavailability of pending block during reseal. * Prevent sync restart if import queue full (#9381) * Add POA Networks: Core and Sokol (#9413) * ethcore: add poa network and sokol chainspecs * rpc: simplify chain spec docs * cli: rearrange networks by main/test and size/range * parity: don't blacklist 0x00a328 on sokol testnet * parity: add sokol and poanet to params and clean up a bit, add tests * ethcore: add the poa networks and clean up a bit * ethcore: fix path to poacore chain spec * parity: rename poa networks to poacore and poasokol * parity: fix configuration tests * parity: fix parameter tests * ethcore: rename POA Core and POA Sokol * Update tobalaba.json (#9419) * Update hardcoded sync (#9421) - Update foundation hardcoded header to block 6219777 - Update ropsten hardcoded header to block 3917825 - Update kovan hardcoded header to block 8511489

sorpaas added 5 commits July 12, 2018 19:27

Completely remove all dapps struct from rpc

f67b25e

Remove unused pub use

0359e3d

Remove dapp policy/permission func in ethcore

ad20fb3

Remove all dapps settings from rpc

82ac926

Fix rpc tests

f21b14b

sorpaas added A0-pleasereview 🤓 Pull request needs code review. F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. labels Jul 13, 2018

sorpaas added this to the 2.1 milestone Jul 13, 2018

5chdn added the B0-patchthis label Jul 14, 2018

5chdn mentioned this pull request Jul 14, 2018

Backports to 2.0.0-beta #9094

Merged

15 tasks

Merge branch 'master' into sp-remove-dapp-permissions

1a4537c

5chdn mentioned this pull request Jul 17, 2018

Backports to 2.0.1-beta #9145

Merged

15 tasks

5chdn modified the milestones: 2.1, 2.2 Jul 17, 2018

debris approved these changes Jul 23, 2018

View reviewed changes

debris requested a review from tomusdrw July 23, 2018 12:01

debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 23, 2018

tomusdrw reviewed Jul 23, 2018

View reviewed changes

tomusdrw added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jul 23, 2018

sorpaas added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Jul 24, 2018

sorpaas added 2 commits July 24, 2018 14:49

Use both origin and user_agent

aedde18

Address grumbles

6a087d9

sorpaas added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jul 24, 2018

sorpaas removed the A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. label Jul 24, 2018

Merge branch 'master' of https://github.com/paritytech/parity into sp…

74bd370

…-remove-dapp-permissions

5chdn added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Jul 24, 2018

5chdn mentioned this pull request Jul 26, 2018

beta backports for 2.0.3 #9229

Merged

28 tasks

5chdn added the B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases. label Jul 30, 2018

tomusdrw approved these changes Aug 7, 2018

View reviewed changes

sorpaas added 2 commits August 7, 2018 18:54

Address grumbles

212ec7e

Fix tests

1d93670

tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 7, 2018

tomusdrw approved these changes Aug 7, 2018

View reviewed changes

sorpaas merged commit 1f18dbb into master Aug 7, 2018

sorpaas deleted the sp-remove-dapp-permissions branch August 7, 2018 12:52

amaury1093 mentioned this pull request Aug 17, 2018

Manage default account on the client side openethereum/fether#182

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove all dapp permissions related settings #9120

Remove all dapp permissions related settings #9120

sorpaas commented Jul 13, 2018

5chdn commented Jul 16, 2018

tomusdrw left a comment

tomusdrw Jul 23, 2018

tomusdrw Jul 23, 2018

tomusdrw Jul 23, 2018

tomusdrw Jul 23, 2018

tomusdrw Jul 23, 2018

sorpaas Jul 24, 2018

tomusdrw Jul 23, 2018

tomusdrw Jul 23, 2018

tomusdrw Jul 23, 2018

tomusdrw Jul 23, 2018

sorpaas Jul 24, 2018

5chdn Jul 24, 2018

tomusdrw Jul 23, 2018

debris commented Aug 7, 2018

tomusdrw left a comment

tomusdrw Aug 7, 2018

amaury1093 commented Aug 17, 2018

Remove all dapp permissions related settings #9120

Remove all dapp permissions related settings #9120

Conversation

sorpaas commented Jul 13, 2018

5chdn commented Jul 16, 2018

tomusdrw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

debris commented Aug 7, 2018

tomusdrw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amaury1093 commented Aug 17, 2018