Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fix verification in ethcore-sync collect_blocks #9135

Merged
merged 1 commit into from
Jul 16, 2018
Merged

fix verification in ethcore-sync collect_blocks #9135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ethcore/sync/src/block_sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,18 +477,19 @@ impl BlockDownloader {
for block_and_receipts in blocks {
let block = block_and_receipts.block;
let receipts = block_and_receipts.receipts;
let (h, number, parent) = {
let header = view!(BlockView, &block).header_view();
(header.hash(), header.number(), header.parent_hash())
};

// Perform basic block verification
if !Block::is_good(&block) {
debug!(target: "sync", "Bad block rlp {:?} : {:?}", h, block);
debug!(target: "sync", "Bad block rlp: {:?}", block);
bad = true;
break;
}

let (h, number, parent) = {
let header = view!(BlockView, &block).header_view();
(header.hash(), header.number(), header.parent_hash())
};

if self.target_hash.as_ref().map_or(false, |t| t == &h) {
self.state = State::Complete;
trace!(target: "sync", "Sync target reached");
Expand Down