Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Allow tx pool to be Send #9315

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Allow tx pool to be Send #9315

merged 1 commit into from
Aug 9, 2018

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Aug 8, 2018

This allows using transaction pool in Arc without specifying bounds all over the high level code.

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Aug 8, 2018
@arkpar arkpar requested a review from tomusdrw August 8, 2018 14:43
tomusdrw
tomusdrw approved these changes Aug 8, 2018
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We should probably move the pool to parity-common as well. CC @dvdplm

@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 8, 2018
@dvdplm
Copy link
Collaborator

dvdplm commented Aug 9, 2018

We should probably move the pool to parity-common

Good idea: paritytech/parity-common#19

@debris debris merged commit 62fdfb9 into master Aug 9, 2018
@debris debris deleted the a-pool-send branch August 9, 2018 21:13
ordian added a commit to ordian/parity that referenced this pull request Aug 10, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
cfd6152 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  Allow setting the panic hook with parity-clib (openethereum#9292)
  Prevent blockchain & miner racing when accessing pending block. (openethereum#9310)
  Docker alpine: use multi-stage concept (openethereum#9269)
  Update `log` -> 0.4, `env_logger` -> 0.5. (openethereum#9294)
  Update tobalaba.json (openethereum#9313)
  Allow tx pool to be Send (openethereum#9315)
  Fix codecov.io badge in README (openethereum#9327)
  Move ethereum-specific H256FastMap type to own crate (openethereum#9307)
  ethcore sync decodes rlp less often (openethereum#9264)
@5chdn 5chdn added this to the 2.1 milestone Aug 21, 2018
@5chdn 5chdn added the M4-core ⛓ Core client code / Rust. label Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.
6 participants
@arkpar @dvdplm @tomusdrw @niklasad1 @debris @5chdn