aura: don't report skipped primaries when empty steps are enabled #9435
Conversation
andresilva
added
A0-pleasereview 🤓
There was a problem hiding this comment.
I think this is okay, as it keeps the behavior aligned with verify_block_family. However, there may still be a way to report skipped when generating seal:
- Gather all current empty_steps proof via
self.empty_steps(..). - Check which block is not in the range, get the primary for that block, and call
report_skippedfor all of them.
That said, I think the root issue is that we didn't include empty steps proof in seal. Our docs for EmptyStep struct still says "Other authorities accumulate these messages and later include them in the seal as proof", so this probably was an intended but not implemented feature.
|
@sorpaas The reason we don't report on skipped empty steps is because these messages are broadcast with no reliable delivery semantics, if you don't receive an empty step message it may be because the authority is offline, or it may also be due to some network constraint (or some rogue agent is blocking the message from reaching you). The empty step messages that an authority accumulates are included in the seal (https://github.com/paritytech/parity-ethereum/blob/master/ethcore/src/engines/authority_round/mod.rs#L1000), this is actually required to verify the block difficulty. |
5chdn
added
A8-looksgood 🦄
* parity-version: bump beta to 2.0.4 * [light/jsonrpc] Provide the actual account for `eth_coinbase` RPC and unify error handeling for light and full client (#9383) * Provide the actual `account` for eth_coinbase The previous implementation always provided the `zero address` on `eth_coinbase` RPC. Now, instead the actual address is returned on success or an error when no account(s) is found! * full client `eth_coinbase` return err In the full-client return an error when no account is found instead of returning the `zero address` * Remove needless blocks on single import * Remove needless `static` lifetime on const * Fix `rpc_eth_author` test * parity: print correct keys path on startup (#9501) * aura: don't report skipped primaries when empty steps are enabled (#9435) * Only check warp syncing for eth_getWorks (#9484) * Only check warp syncing for eth_getWorks * Use SyncStatus::is_snapshot_syncing * Fix Snapshot restoration failure on Windows (#9491) * Close Blooms DB files before DB restoration * PR Grumbles I * PR Grumble * Grumble
Fix #9325.
When empty steps are enabled we cannot report skipped primaries since we have no meaningful way to prove that the authority didn't actually broadcast an empty step message. This is already the existing behavior when verifying blocks (https://github.com/paritytech/parity-ethereum/blob/master/ethcore/src/engines/authority_round/mod.rs#L1146-L1180).